Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: pkg/compiler/lib/src/kernel/element_map_impl.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)
Patch Set: More issues discovered during testing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/element_map_impl.dart
diff --git a/pkg/compiler/lib/src/kernel/element_map_impl.dart b/pkg/compiler/lib/src/kernel/element_map_impl.dart
index ceed52be3b4225a171c7e00c8eba5819b8e2d1e7..045b025a7a469e912a5534caace7db704b1628c1 100644
--- a/pkg/compiler/lib/src/kernel/element_map_impl.dart
+++ b/pkg/compiler/lib/src/kernel/element_map_impl.dart
@@ -756,7 +756,7 @@ class KernelToElementMapImpl extends KernelToElementMapMixin {
}
@override
- ir.Member getMemberNode(KMember member) {
+ ir.Member getMemberNode(covariant KMember member) {
return _memberList[member.memberIndex].node;
}
@@ -1190,12 +1190,12 @@ class KernelElementEnvironment implements ElementEnvironment {
}
@override
- bool isMixinApplication(KClass cls) {
+ bool isMixinApplication(covariant KClass cls) {
return elementMap._isMixinApplication(cls);
}
@override
- bool isUnnamedMixinApplication(KClass cls) {
+ bool isUnnamedMixinApplication(covariant KClass cls) {
return elementMap._isUnnamedMixinApplication(cls);
}
@@ -1221,12 +1221,12 @@ class KernelElementEnvironment implements ElementEnvironment {
}
@override
- FunctionType getFunctionType(KFunction function) {
+ FunctionType getFunctionType(covariant KFunction function) {
return elementMap._getFunctionType(function);
}
@override
- FunctionType getLocalFunctionType(KLocalFunction function) {
+ FunctionType getLocalFunctionType(covariant KLocalFunction function) {
return function.functionType;
}
@@ -1323,7 +1323,7 @@ class KernelElementEnvironment implements ElementEnvironment {
}
@override
- void forEachClass(KLibrary library, void f(ClassEntity cls)) {
+ void forEachClass(covariant KLibrary library, void f(ClassEntity cls)) {
elementMap._forEachClass(library, f);
}
@@ -1338,13 +1338,13 @@ class KernelElementEnvironment implements ElementEnvironment {
}
@override
- bool isDeferredLoadLibraryGetter(KMember member) {
+ bool isDeferredLoadLibraryGetter(covariant KMember member) {
// TODO(johnniwinther): Support these.
return false;
}
@override
- Iterable<ConstantValue> getMemberMetadata(KMember member) {
+ Iterable<ConstantValue> getMemberMetadata(covariant KMember member) {
_MemberData memberData = elementMap._memberList[member.memberIndex];
return memberData.getMetadata(elementMap);
}
@@ -1708,13 +1708,14 @@ class KernelNativeMemberResolver extends NativeMemberResolverBase {
CommonElements get commonElements => elementMap.commonElements;
@override
- native.NativeBehavior computeNativeFieldStoreBehavior(KField field) {
+ native.NativeBehavior computeNativeFieldStoreBehavior(
+ covariant KField field) {
ir.Field node = elementMap._memberList[field.memberIndex].node;
return elementMap.getNativeBehaviorForFieldStore(node);
}
@override
- native.NativeBehavior computeNativeFieldLoadBehavior(KField field,
+ native.NativeBehavior computeNativeFieldLoadBehavior(covariant KField field,
{bool isJsInterop}) {
ir.Field node = elementMap._memberList[field.memberIndex].node;
return elementMap.getNativeBehaviorForFieldLoad(node,
@@ -1722,7 +1723,8 @@ class KernelNativeMemberResolver extends NativeMemberResolverBase {
}
@override
- native.NativeBehavior computeNativeMethodBehavior(KFunction function,
+ native.NativeBehavior computeNativeMethodBehavior(
+ covariant KFunction function,
{bool isJsInterop}) {
ir.Member node = elementMap._memberList[function.memberIndex].node;
return elementMap.getNativeBehaviorForMethod(node,
@@ -1730,7 +1732,7 @@ class KernelNativeMemberResolver extends NativeMemberResolverBase {
}
@override
- bool isNativeMethod(KFunction function) {
+ bool isNativeMethod(covariant KFunction function) {
if (!native.maybeEnableNative(function.library.canonicalUri)) return false;
ir.Member node = elementMap._memberList[function.memberIndex].node;
return node.isExternal &&
« no previous file with comments | « pkg/compiler/lib/src/kernel/element_map.dart ('k') | pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698