Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: pkg/testing/lib/src/analyze.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)
Patch Set: More issues discovered during testing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/tool/track_memory.dart ('k') | tests/compiler/dart2js/analysis_options.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/analyze.dart
diff --git a/pkg/testing/lib/src/analyze.dart b/pkg/testing/lib/src/analyze.dart
index fa2ccd5c6846f80e59f75debde0a974df4131c51..ec67cd4b3d401d7263b14bc2d18eaa50188dfc00 100644
--- a/pkg/testing/lib/src/analyze.dart
+++ b/pkg/testing/lib/src/analyze.dart
@@ -237,14 +237,6 @@ Future<Null> analyzeUris(
await for (AnalyzerDiagnostic diagnostic in diagnostics) {
if (diagnostic.uri != null) {
String path = toFilePath(diagnostic.uri);
- if (!(analysisOptions?.path?.contains("/pkg/compiler/") ?? false) &&
- diagnostic.code.startsWith("STRONG_MODE") &&
- (path.startsWith("pkg/compiler/") ||
- path.startsWith("tests/compiler/dart2js/"))) {
- // TODO(ahe): Remove this hack to work around dart2js not being
- // strong-mode clean.
- continue;
- }
if (!filesToAnalyze.contains(path)) continue;
}
String message = "$diagnostic";
« no previous file with comments | « pkg/compiler/tool/track_memory.dart ('k') | tests/compiler/dart2js/analysis_options.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698