Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: tests/compiler/dart2js/quarantined/http_test.dart

Issue 2944843002: All strong mode cleaning of dart2js. (Closed)
Patch Set: More issues discovered during testing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/parser_helper.dart ('k') | tests/compiler/dart2js/related_types_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/quarantined/http_test.dart
diff --git a/tests/compiler/dart2js/quarantined/http_test.dart b/tests/compiler/dart2js/quarantined/http_test.dart
index 11320290e02f18ccfb04ac9eb6e6912a4ed73f8e..d28805f9cd76289e073f8767434e6824d22c462f 100644
--- a/tests/compiler/dart2js/quarantined/http_test.dart
+++ b/tests/compiler/dart2js/quarantined/http_test.dart
@@ -50,7 +50,6 @@ void check(ProcessResult result) {
void checkNotFound(ProcessResult result, String filename) {
Expect.notEquals(0, result.exitCode);
- File outFile = new File(outFilePath);
Expect.isTrue(result.stdout.contains("404"));
Expect.isTrue(result.stdout.contains(filename));
}
@@ -164,13 +163,19 @@ Future testHttp() {
void initializeSSL() {
Uri pathOfPkcert = pathOfData.resolve('pkcert');
String testPkcertDatabase = pathOfPkcert.toFilePath();
+ // Issue 29926.
+ // ignore: UNDEFINED_METHOD
SecureSocket.initialize(database: testPkcertDatabase, password: 'dartdart');
}
Future testHttps() {
initializeSSL();
return HttpServer
+ // Issue 29926.
+ // ignore: NOT_ENOUGH_REQUIRED_ARGUMENTS
.bindSecure(InternetAddress.LOOPBACK_IP_V4, 0,
+ // Issue 29926.
+ // ignore: UNDEFINED_NAMED_PARAMETER
certificateName: 'localhost_cert')
.then((HttpServer server) => serverRunning(server, "https"));
}
« no previous file with comments | « tests/compiler/dart2js/parser_helper.dart ('k') | tests/compiler/dart2js/related_types_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698