All strong mode cleaning of dart2js.

pkg/compiler/lib/src/ssa/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import '../closure.dart';
 import '../common.dart';
 import '../common_elements.dart' show CommonElements;
 import '../compiler.dart' show Compiler;
 import '../constants/constant_system.dart';
 import '../constants/values.dart';
@@ skipping 1193 matching lines @@
     int length = inputs.length;
     for (int i = 0; i < length; i++) {
       result = (result * 19) + (inputs[i].nonCheck().id) + (result >> 7);
     }
     return result;
   }
 
   // These methods should be overwritten by instructions that
   // participate in global value numbering.
   int typeCode() => HInstruction.UNDEFINED_TYPECODE;
-  bool typeEquals(HInstruction other) => false;
-  bool dataEquals(HInstruction other) => false;
+  bool typeEquals(covariant HInstruction other) => false;
+  bool dataEquals(covariant HInstruction other) => false;
 
   accept(HVisitor visitor);
 
   void notifyAddedToBlock(HBasicBlock targetBlock) {
     assert(!isInBasicBlock());
     assert(block == null);
     // Add [this] to the inputs' uses.
     for (int i = 0; i < inputs.length; i++) {
       assert(inputs[i].isInBasicBlock());
       inputs[i].usedBy.add(this);
@@ skipping 462 matching lines @@
 
 abstract class HInvokeDynamic extends HInvoke {
   final InvokeDynamicSpecializer specializer;
   Selector selector;
   TypeMask mask;
   MemberEntity element;
 
   HInvokeDynamic(Selector selector, this.mask, this.element,
       List<HInstruction> inputs, TypeMask type,
       [bool isIntercepted = false])
-      : super(inputs, type),
-        this.selector = selector,
+      : this.selector = selector,
         specializer = isIntercepted
             ? InvokeDynamicSpecializer.lookupSpecializer(selector)
-            : const InvokeDynamicSpecializer();
+            : const InvokeDynamicSpecializer(),
+        super(inputs, type);
   toString() => 'invoke dynamic: selector=$selector, mask=$mask';
   HInstruction get receiver => inputs[0];
   HInstruction getDartReceiver(ClosedWorld closedWorld) {
     return isCallOnInterceptor(closedWorld) ? inputs[1] : inputs[0];
   }
 
   /**
    * Returns whether this call is on an interceptor object.
    */
   bool isCallOnInterceptor(ClosedWorld closedWorld) {
@@ skipping 792 matching lines @@
   }
 
   toString() => 'parameter ${sourceElement.name}';
   accept(HVisitor visitor) => visitor.visitParameterValue(this);
 }
 
 class HThis extends HParameterValue {
   HThis(ThisLocal element, TypeMask type) : super(element, type);
 
   ThisLocal get sourceElement => super.sourceElement;
-  void set sourceElement(ThisLocal local) {
+  void set sourceElement(covariant ThisLocal local) {
     super.sourceElement = local;
   }
 
   accept(HVisitor visitor) => visitor.visitThis(this);
 
   bool isCodeMotionInvariant() => true;
 
   bool isInterceptor(ClosedWorld closedWorld) {
     return closedWorld.interceptorData
         .isInterceptedClass(sourceElement.enclosingClass);
@@ skipping 468 matching lines @@
       : checkedType = type,
         super(<HInstruction>[input], type) {
     assert(!isReceiverTypeCheck || receiverTypeCheckSelector != null);
     assert(typeExpression == null || !typeExpression.isTypedef);
     sourceElement = input.sourceElement;
   }
 
   HTypeConversion.withTypeRepresentation(this.typeExpression, this.kind,
       TypeMask type, HInstruction input, HInstruction typeRepresentation)
       : checkedType = type,
-        super(<HInstruction>[input, typeRepresentation], type),
-        receiverTypeCheckSelector = null {
+        receiverTypeCheckSelector = null,
+        super(<HInstruction>[input, typeRepresentation], type) {
     assert(!typeExpression.isTypedef);
     sourceElement = input.sourceElement;
   }
 
   HTypeConversion.viaMethodOnType(this.typeExpression, this.kind, TypeMask type,
       HInstruction reifiedType, HInstruction input)
       : checkedType = type,
-        super(<HInstruction>[reifiedType, input], type),
-        receiverTypeCheckSelector = null {
+        receiverTypeCheckSelector = null,
+        super(<HInstruction>[reifiedType, input], type) {
     // This form is currently used only for function types.
     assert(typeExpression.isFunctionType);
     assert(kind == CHECKED_MODE_CHECK || kind == CAST_TYPE_CHECK);
     sourceElement = input.sourceElement;
   }
 
   bool get hasTypeRepresentation {
     return typeExpression.isInterfaceType && inputs.length > 1;
   }
 
@@ skipping 519 matching lines @@
   // ignore: MISSING_RETURN
   String get kindAsString {
     switch (kind) {
       case TypeInfoExpressionKind.COMPLETE:
         return 'COMPLETE';
       case TypeInfoExpressionKind.INSTANCE:
         return 'INSTANCE';
     }
   }
 }