DO NOT SUBMIT results of new clang-format

DO NOT SUBMIT: results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname '*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f -iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

[Dan Beam, 2017-06-14 22:49:22]

Description was changed from

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

BUG=567770
==========

to

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-06-14 22:49:25]

Description was changed from

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Dan Beam, 2017-06-14 22:49:28]

Description was changed from

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Dan Beam, 2017-06-14 22:49:31]

Description was changed from

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Dan Beam, 2017-06-14 22:50:56]

Description was changed from

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Dan Beam, 2017-06-14 22:52:52]

Description was changed from

==========
DO NOT SUBMIT: Results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
DO NOT SUBMIT: results of new clang-format

$ buildtools/linux64/clang-format --version
clang-format version 5.0.0 (trunk 302580)

$ stat buildtools/linux64/clang-format | egrep -o 'Size: [0-9]+'
Size: 1647896

$ time find third_party/WebKit/ -type f -iname '*.h' -o -iname '*.cc' -o -iname
'*.mm' -o -iname '*.cpp' | xargs buildtools/linux64/clang-format -i
real    2m14.790s
user    2m12.541s
sys     0m1.902s

$ time find ui/webui chrome/browser/resources/md_{bookmarks,history} -type f
-iname '*.js' | xargs buildtools/linux64/clang-format -i
real    0m1.521s
user    0m1.451s
sys     0m0.069s

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2017-06-15 20:28:04]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-06-15 20:28:09]

I guess the big new thing is the auto-insertion of namespace end comments.

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/ConsoleTypes.h (right):

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/ConsoleTypes.h:32: }  // namespace
blink
whoa

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTableRow.cpp (right):

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTableRow.cpp:8: *               
Apple Inc.
wat

(https://bugs.llvm.org/show_bug.cgi?id=33474)

[Dan Beam, 2017-06-15 22:54:42]

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/ConsoleTypes.h (right):

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/ConsoleTypes.h:32: }  // namespace
blink
On 2017/06/15 20:28:09, Nico wrote:
> whoa

Acknowledged.

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/audio/SincResampler.cpp (right):

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/SincResampler.cpp:355:
CONVOLVE_ONE_SAMPLE                                              // 1
this is more "wat", imo.  i think these all just need ; at the end to fool
clang-format or a // clang-format off comment

[Nico, 2017-06-15 23:00:13]

Or I can do it tomorrow

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/audio/SincResampler.cpp (right):

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/SincResampler.cpp:355:
CONVOLVE_ONE_SAMPLE                                              // 1
On 2017/06/15 22:54:42, Dan Beam wrote:
> this is more "wat", imo.  i think these all just need ; at the end to fool
> clang-format or a // clang-format off comment

Yeah...can you add ;s here please?

[Raymond Toy, 2017-06-15 23:03:31]

rtoy@chromium.org changed reviewers:
+ rtoy@chromium.org

[Raymond Toy, 2017-06-15 23:03:38]

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/audio/SincResampler.cpp (right):

https://codereview.chromium.org/2940933003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/SincResampler.cpp:355:
CONVOLVE_ONE_SAMPLE                                              // 1
On 2017/06/15 23:00:13, Nico wrote:
> On 2017/06/15 22:54:42, Dan Beam wrote:
> > this is more "wat", imo.  i think these all just need ; at the end to fool
> > clang-format or a // clang-format off comment
> 
> Yeah...can you add ;s here please?

DBC: I'd be perfectly happy to rewrite these macros to do 
do {
 stuff
} while (1)

This has always annoyed me about this code.

[Nico, 2017-06-15 23:14:20]

You can just add a ; at line end without needing do-while. (You can remove
the last ; from the macro definition to require that.)

Do-while is only needed if you need a local scope.

On Jun 15, 2017 7:03 PM, "rtoy@chromium.org via codereview.chromium.org" <
reply@chromiumcodereview-hr.appspotmail.com> wrote:

>
> https://codereview.chromium.org/2940933003/diff/1/third_
> party/WebKit/Source/platform/audio/SincResampler.cpp
> File third_party/WebKit/Source/platform/audio/SincResampler.cpp (right):
>
> https://codereview.chromium.org/2940933003/diff/1/third_
> party/WebKit/Source/platform/audio/SincResampler.cpp#newcode355
> third_party/WebKit/Source/platform/audio/SincResampler.cpp:355:
> CONVOLVE_ONE_SAMPLE // 1
> On 2017/06/15 23:00:13, Nico wrote:
> > On 2017/06/15 22:54:42, Dan Beam wrote:
> > > this is more "wat", imo. i think these all just need ; at the end
> to fool
> > > clang-format or a // clang-format off comment
> >
> > Yeah...can you add ;s here please?
>
> DBC: I'd be perfectly happy to rewrite these macros to do
> do {
> stuff
> } while (1)
>
> This has always annoyed me about this code.
>
> https://codereview.chromium.org/2940933003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2017-06-15 23:14:21]

You can just add a ; at line end without needing do-while. (You can remove
the last ; from the macro definition to require that.)

Do-while is only needed if you need a local scope.

On Jun 15, 2017 7:03 PM, "rtoy@chromium.org via codereview.chromium.org" <
reply@chromiumcodereview-hr.appspotmail.com> wrote:

>
> https://codereview.chromium.org/2940933003/diff/1/third_
> party/WebKit/Source/platform/audio/SincResampler.cpp
> File third_party/WebKit/Source/platform/audio/SincResampler.cpp (right):
>
> https://codereview.chromium.org/2940933003/diff/1/third_
> party/WebKit/Source/platform/audio/SincResampler.cpp#newcode355
> third_party/WebKit/Source/platform/audio/SincResampler.cpp:355:
> CONVOLVE_ONE_SAMPLE // 1
> On 2017/06/15 23:00:13, Nico wrote:
> > On 2017/06/15 22:54:42, Dan Beam wrote:
> > > this is more "wat", imo. i think these all just need ; at the end
> to fool
> > > clang-format or a // clang-format off comment
> >
> > Yeah...can you add ;s here please?
>
> DBC: I'd be perfectly happy to rewrite these macros to do
> do {
> stuff
> } while (1)
>
> This has always annoyed me about this code.
>
> https://codereview.chromium.org/2940933003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Yuta Kitamura, 2017-06-16 04:49:17]

On 2017/06/15 23:14:21, Nico wrote:
> You can just add a ; at line end without needing do-while. (You can remove
> the last ; from the macro definition to require that.)
> 
> Do-while is only needed if you need a local scope.

Or if you need to hang the macro under an "if" conditional (or
similar) without a brace, e.g.

    if (foo)
        MACRO;
    else
        boo;

Neither is the case here, so it's OK to do without do-while.

However, doing do-while is generally a good practice and there's
no downsides, so I'm not opposed to doing do-while here.

[Yuta Kitamura, 2017-06-16 04:49:29]

On 2017/06/15 23:14:21, Nico wrote:
> You can just add a ; at line end without needing do-while. (You can remove
> the last ; from the macro definition to require that.)
> 
> Do-while is only needed if you need a local scope.

Or if you need to hang the macro under an "if" conditional (or
similar) without a brace, e.g.

    if (foo)
        MACRO;
    else
        boo;

Neither is the case here, so it's OK to do without do-while.

However, doing do-while is generally a good practice and there's
no downsides, so I'm not opposed to doing do-while here.