Fill has_password_field for password reuse ping

Fill has_password_field for password reuse ping

BUG=730107
Review-Url: https://codereview.chromium.org/2929533002
Cr-Commit-Position: refs/heads/master@{#478115}
Committed: https://chromium.googlesource.com/chromium/src/+/f77d4b0816dfa75bb4e6ebc452ba5f8a7e941c30

[Jialiu Lin, 2017-06-06 21:08:18]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 21:08:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 22:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 22:10:30]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2017-06-06 22:12:29]

jialiul@chromium.org changed reviewers:
+ dvadym@chromium.org, lpz@chromium.org, nparker@chromium.org

[lpz, 2017-06-07 13:54:24]

lgtm

https://codereview.chromium.org/2929533002/diff/1/components/safe_browsing/pa...
File components/safe_browsing/password_protection/password_protection_request.h
(right):

https://codereview.chromium.org/2929533002/diff/1/components/safe_browsing/pa...
components/safe_browsing/password_protection/password_protection_request.h:135:
const bool has_password_field;
include the trailing _

nit: also consider renaming so it doesn't start with "has_" since that makes it
look like you're checking for the presence of a proto field called
"password_field". Although that might not be a huge issue in the chrome
codebase. Perhaps "password_field_exists_"?

[dvadym, 2017-06-07 14:07:34]

LGTM

[Jialiu Lin, 2017-06-07 21:11:50]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[Jialiu Lin, 2017-06-07 21:12:33]

Thanks lpz@ and dvadym@!

https://codereview.chromium.org/2929533002/diff/1/components/safe_browsing/pa...
File components/safe_browsing/password_protection/password_protection_request.h
(right):

https://codereview.chromium.org/2929533002/diff/1/components/safe_browsing/pa...
components/safe_browsing/password_protection/password_protection_request.h:135:
const bool has_password_field;
On 2017/06/07 13:54:24, lpz wrote:
> include the trailing _
> 
> nit: also consider renaming so it doesn't start with "has_" since that makes
it
> look like you're checking for the presence of a proto field called
> "password_field". Although that might not be a huge issue in the chrome
> codebase. Perhaps "password_field_exists_"?

Ah, can't believe I made this mistake. And "password_field_exists_" sounds much
better. Thanks for this suggestion!

[commit-bot: I haz the power, 2017-06-07 21:13:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 21:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:26:30]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Nathan Parker, 2017-06-08 18:40:05]

lgtm

[Jialiu Lin, 2017-06-08 19:31:15]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 19:31:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 19:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 19:34:50]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jialiu Lin, 2017-06-08 20:30:58]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 20:31:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 20:59:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 20:59:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jialiu Lin, 2017-06-08 21:10:25]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 21:11:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-06-08 22:36:56]

The CQ bit was unchecked by jialiul@chromium.org

[Jialiu Lin, 2017-06-08 22:37:04]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2017-06-08 22:37:04]

The patchset sent to the CQ was uploaded after l-g-t-m from lpz@chromium.org,
dvadym@chromium.org, nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/2929533002/#ps60001
(title: "fix broken test due to rebase")

[commit-bot: I haz the power, 2017-06-08 22:37:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 23:02:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496961424527220,
"parent_rev": "660101f220ca79409db7450d980ba2f10888400f", "commit_rev":
"f77d4b0816dfa75bb4e6ebc452ba5f8a7e941c30"}

[commit-bot: I haz the power, 2017-06-08 23:02:31]

Description was changed from

==========
Fill has_password_field for password reuse ping

BUG=730107
==========

to

==========
Fill has_password_field for password reuse ping

BUG=730107

Review-Url: https://codereview.chromium.org/2929533002
Cr-Commit-Position: refs/heads/master@{#478115}
Committed:
https://chromium.googlesource.com/chromium/src/+/f77d4b0816dfa75bb4e6ebc452ba...
==========

[commit-bot: I haz the power, 2017-06-08 23:02:32]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f77d4b0816dfa75bb4e6ebc452ba...