Fill has_password_field for password reuse ping

components/safe_browsing/password_protection/password_protection_request.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_PASSWORD_PROTECTION_PASSWORD_PROTECTION_REQUEST_H_
 #define COMPONENTS_SAFE_BROWSING_PASSWORD_PROTECTION_PASSWORD_PROTECTION_REQUEST_H_
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/task/cancelable_task_tracker.h"
@@ skipping 28 matching lines @@
                                       PasswordProtectionRequest,
                                       content::BrowserThread::DeleteOnUIThread>,
                                   public net::URLFetcherDelegate {
  public:
   PasswordProtectionRequest(content::WebContents* web_contents,
                             const GURL& main_frame_url,
                             const GURL& password_form_action,
                             const GURL& password_form_frame_url,
                             const std::string& saved_domain,
                             LoginReputationClientRequest::TriggerType type,
+                            bool has_password_field,
                             PasswordProtectionService* pps,
                             int request_timeout_in_ms);
 
   base::WeakPtr<PasswordProtectionRequest> GetWeakPtr() {
     return weakptr_factory_.GetWeakPtr();
   }
 
   // Starts processing request by checking extended reporting and incognito
   // conditions.
   void Start();
@@ skipping 64 matching lines @@
 
   // Frame url of the detected password form.
   const GURL password_form_frame_url_;
 
   // Domain on which a password is saved and gets reused.
   const std::string saved_domain_;
 
   // If this request is for unfamiliar login page or for a password reuse event.
   const LoginReputationClientRequest::TriggerType request_type_;
 
+  // If there is a password field on the page.
+  const bool has_password_field;

[lpz, 2017/06/07 13:54:24]

include the trailing _

nit: also consider renaming so it doesn't start with "has_" since that makes it
look like you're checking for the presence of a proto field called
"password_field". Although that might not be a huge issue in the chrome
codebase. Perhaps "password_field_exists_"?

[Jialiu Lin, 2017/06/07 21:12:33]

Ah, can't believe I made this mistake. And "password_field_exists_" sounds much
better. Thanks for this suggestion!

+
   // When request is sent.
   base::TimeTicks request_start_time_;
 
   // URLFetcher instance for sending request and receiving response.
   std::unique_ptr<net::URLFetcher> fetcher_;
 
   // The PasswordProtectionService instance owns |this|.
   // Can only be accessed on UI thread.
   PasswordProtectionService* password_protection_service_;
 
   // If we haven't receive response after this period of time, we cancel this
   // request.
   const int request_timeout_in_ms_;
 
   std::unique_ptr<LoginReputationClientRequest> request_proto_;
 
   // Needed for canceling tasks posted to different threads.
   base::CancelableTaskTracker tracker_;
 
   base::WeakPtrFactory<PasswordProtectionRequest> weakptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(PasswordProtectionRequest);
 };
 
 }  // namespace safe_browsing
 
 #endif  // COMPONENTS_SAFE_BROWSING_PASSWORD_PROTECTION_PASSWORD_PROTECTION_REQUEST_H_