Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: components/safe_browsing/password_protection/password_protection_request.cc

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)
Patch Set: fix broken test due to rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_request.cc
diff --git a/components/safe_browsing/password_protection/password_protection_request.cc b/components/safe_browsing/password_protection/password_protection_request.cc
index 245dcf9289f04df15f439b4fd0126be3185897ad..909c84891e2452a12116414b9145652ae3daea56 100644
--- a/components/safe_browsing/password_protection/password_protection_request.cc
+++ b/components/safe_browsing/password_protection/password_protection_request.cc
@@ -28,6 +28,7 @@ PasswordProtectionRequest::PasswordProtectionRequest(
const GURL& password_form_frame_url,
const std::string& saved_domain,
LoginReputationClientRequest::TriggerType type,
+ bool password_field_exists,
PasswordProtectionService* pps,
int request_timeout_in_ms)
: web_contents_(web_contents),
@@ -36,6 +37,7 @@ PasswordProtectionRequest::PasswordProtectionRequest(
password_form_frame_url_(password_form_frame_url),
saved_domain_(saved_domain),
request_type_(type),
+ password_field_exists_(password_field_exists),
password_protection_service_(pps),
request_timeout_in_ms_(request_timeout_in_ms),
weakptr_factory_(this) {
@@ -126,6 +128,7 @@ void PasswordProtectionRequest::FillRequestProto() {
break;
}
case LoginReputationClientRequest::PASSWORD_REUSE_EVENT: {
+ main_frame->set_has_password_field(password_field_exists_);
LoginReputationClientRequest::PasswordReuseEvent* reuse_event =
request_proto_->mutable_password_reuse_event();
reuse_event->set_is_chrome_signin_password(

Powered by Google App Engine
This is Rietveld 408576698