components/password_manager/core/browser/password_reuse_detection_manager.cc - Issue 2929533002: Fill has_password_field for password reuse ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_reuse_detection_manager.cc

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)

Patch Set: fix broken test due to rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_client.h ('k') | components/password_manager/core/browser/stub_password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_reuse_detection_manager.cc

diff --git a/components/password_manager/core/browser/password_reuse_detection_manager.cc b/components/password_manager/core/browser/password_reuse_detection_manager.cc

index 49a0691399e0a7c90b1a21ea00a0efc839df3917..27dd293128526c3fde5b40060f17e7f0c66fbee8 100644

--- a/components/password_manager/core/browser/password_reuse_detection_manager.cc

+++ b/components/password_manager/core/browser/password_reuse_detection_manager.cc

@@ -94,7 +94,8 @@ void PasswordReuseDetectionManager::OnReuseFound(

#if defined(SAFE_BROWSING_DB_LOCAL)

// TODO(jialiul): After CSD whitelist being added to Android, we should gate

// this by either SAFE_BROWSING_DB_LOCAL or SAFE_BROWSING_DB_REMOTE.

- client_->CheckProtectedPasswordEntry(legitimate_domain);

+ client_->CheckProtectedPasswordEntry(legitimate_domain,

+ password_field_detected);

#endif

}