components/password_manager/core/browser/stub_password_manager_client.cc - Issue 2929533002: Fill has_password_field for password reuse ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.cc

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)

Patch Set: fix broken test due to rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/stub_password_manager_client.h ('k') | components/safe_browsing/password_protection/password_protection_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/stub_password_manager_client.cc

diff --git a/components/password_manager/core/browser/stub_password_manager_client.cc b/components/password_manager/core/browser/stub_password_manager_client.cc

index 309c877e94654a0c047e8d7f0e0f4c5c002771f0..6c8b37f7549e28cbd9ed8e8e000b48b499584fd1 100644

--- a/components/password_manager/core/browser/stub_password_manager_client.cc

+++ b/components/password_manager/core/browser/stub_password_manager_client.cc

@@ -75,7 +75,8 @@ void StubPasswordManagerClient::CheckSafeBrowsingReputation(

const GURL& frame_url) {}

void StubPasswordManagerClient::CheckProtectedPasswordEntry(

- const std::string& password_saved_domain) {}

+ const std::string& password_saved_domain,

+ bool password_field_exists) {}

#endif

} // namespace password_manager