components/password_manager/core/browser/password_manager_client.h - Issue 2929533002: Fill has_password_field for password reuse ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)

Patch Set: fix broken test due to rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_manager_client.h

diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h

index 7004aee79abcdbf891c14210ec25f3bebbf38feb..13cf9451ec7c5f1154c2e2325bcf3a34e1d9be6c 100644

--- a/components/password_manager/core/browser/password_manager_client.h

+++ b/components/password_manager/core/browser/password_manager_client.h

@@ -211,7 +211,8 @@ class PasswordManagerClient {

// Checks the safe browsing reputation of the webpage where password reuse

// happens.

virtual void CheckProtectedPasswordEntry(

- const std::string& password_saved_domain) = 0;

+ const std::string& password_saved_domain,

+ bool password_field_exists) = 0;

#endif

private: