chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc - Issue 2929533002: Fill has_password_field for password reuse ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)

Patch Set: fix broken test due to rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('k') | components/password_manager/core/browser/password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc b/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

index 348c10c57ec08215e08d782b22efcc44833b8879..e7670c2cdd46188b7b79f9595c8d6cdd24e92f96 100644

--- a/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

@@ -134,7 +134,7 @@ class ChromePasswordProtectionServiceTest

void InitializeRequest(LoginReputationClientRequest::TriggerType type) {

request_ = new PasswordProtectionRequest(web_contents(), GURL(kPhishingURL),

GURL(), GURL(), std::string(),

- type, service_.get(), 0);

+ type, true, service_.get(), 0);

}

void InitializeVerdict(LoginReputationClientResponse::VerdictType type) {