Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Unified Diff: components/safe_browsing/password_protection/password_protection_service_unittest.cc

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)
Patch Set: fix broken test due to rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing/password_protection/password_protection_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/password_protection/password_protection_service_unittest.cc
diff --git a/components/safe_browsing/password_protection/password_protection_service_unittest.cc b/components/safe_browsing/password_protection/password_protection_service_unittest.cc
index 78d638d507d8abb90bb828f27852b2cf6924c119..d297ef1895e5566aff46776ae228bc528360bfe1 100644
--- a/components/safe_browsing/password_protection/password_protection_service_unittest.cc
+++ b/components/safe_browsing/password_protection/password_protection_service_unittest.cc
@@ -173,7 +173,7 @@ class PasswordProtectionServiceTest : public testing::Test {
request_ = new PasswordProtectionRequest(
nullptr, target_url, GURL(kFormActionUrl), GURL(kPasswordFrameUrl),
std::string(), LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE,
- password_protection_service_.get(), timeout_in_ms);
+ true, password_protection_service_.get(), timeout_in_ms);
request_->Start();
}
@@ -186,7 +186,7 @@ class PasswordProtectionServiceTest : public testing::Test {
request_ = new PasswordProtectionRequest(
nullptr, target_url, GURL(), GURL(), saved_domain,
- LoginReputationClientRequest::PASSWORD_REUSE_EVENT,
+ LoginReputationClientRequest::PASSWORD_REUSE_EVENT, true,
password_protection_service_.get(), timeout_in_ms);
request_->Start();
}
@@ -550,7 +550,7 @@ TEST_F(PasswordProtectionServiceTest, TestTearDownWithPendingRequests) {
password_protection_service_->StartRequest(
nullptr, target_url, GURL("http://foo.com/submit"),
GURL("http://foo.com/frame"), std::string(),
- LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE);
+ LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE, true);
// Destroy password_protection_service_ while there is one request pending.
password_protection_service_.reset();
@@ -653,6 +653,7 @@ TEST_F(PasswordProtectionServiceTest, VerifyPasswordProtectionRequestProto) {
actual_request->trigger_type());
EXPECT_EQ(1, actual_request->frames_size());
EXPECT_EQ(kTargetUrl, actual_request->frames(0).url());
+ EXPECT_TRUE(actual_request->frames(0).has_password_field());
ASSERT_TRUE(actual_request->has_password_reuse_event());
ASSERT_TRUE(
actual_request->password_reuse_event().is_chrome_signin_password());
« no previous file with comments | « components/safe_browsing/password_protection/password_protection_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698