Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: components/safe_browsing/password_protection/password_protection_service.cc

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)
Patch Set: fix broken test due to rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_service.cc
diff --git a/components/safe_browsing/password_protection/password_protection_service.cc b/components/safe_browsing/password_protection/password_protection_service.cc
index a16ef3afd719de6a893d9adbc83b0685b1ec5030..c7ec2a9da6a9fde1039c7fe0a56bd3bad6657ce8 100644
--- a/components/safe_browsing/password_protection/password_protection_service.cc
+++ b/components/safe_browsing/password_protection/password_protection_service.cc
@@ -272,13 +272,14 @@ void PasswordProtectionService::StartRequest(
const GURL& password_form_action,
const GURL& password_form_frame_url,
const std::string& saved_domain,
- LoginReputationClientRequest::TriggerType type) {
+ LoginReputationClientRequest::TriggerType type,
+ bool password_field_exists) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
scoped_refptr<PasswordProtectionRequest> request(
- new PasswordProtectionRequest(web_contents, main_frame_url,
- password_form_action,
- password_form_frame_url, saved_domain, type,
- this, GetRequestTimeoutInMS()));
+ new PasswordProtectionRequest(
+ web_contents, main_frame_url, password_form_action,
+ password_form_frame_url, saved_domain, type, password_field_exists,
+ this, GetRequestTimeoutInMS()));
DCHECK(request);
request->Start();
requests_.insert(std::move(request));
@@ -294,18 +295,20 @@ void PasswordProtectionService::MaybeStartPasswordFieldOnFocusRequest(
StartRequest(web_contents, main_frame_url, password_form_action,
password_form_frame_url,
std::string(), /* saved_domain: not used for this type */
- LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE);
+ LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE, true);
}
}
void PasswordProtectionService::MaybeStartProtectedPasswordEntryRequest(
WebContents* web_contents,
const GURL& main_frame_url,
- const std::string& saved_domain) {
+ const std::string& saved_domain,
+ bool password_field_exists) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (CanSendPing(kProtectedPasswordEntryPinging, main_frame_url)) {
StartRequest(web_contents, main_frame_url, GURL(), GURL(), saved_domain,
- LoginReputationClientRequest::PASSWORD_REUSE_EVENT);
+ LoginReputationClientRequest::PASSWORD_REUSE_EVENT,
+ password_field_exists);
}
}

Powered by Google App Engine
This is Rietveld 408576698