chrome/browser/password_manager/chrome_password_manager_client_unittest.cc - Issue 2929533002: Fill has_password_field for password reuse ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)

Patch Set: fix broken test due to rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

index de65bda211153e7aa18f5efeefc3c28221bd025a..eb0011af34137b0f82112ae891be81bc0967ae57 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

@@ -87,8 +87,8 @@ class MockPasswordProtectionService

MOCK_METHOD0(IsHistorySyncEnabled, bool());

MOCK_METHOD4(MaybeStartPasswordFieldOnFocusRequest,

void(WebContents*, const GURL&, const GURL&, const GURL&));

- MOCK_METHOD3(MaybeStartProtectedPasswordEntryRequest,

- void(WebContents*, const GURL&, const std::string&));

+ MOCK_METHOD4(MaybeStartProtectedPasswordEntryRequest,

+ void(WebContents*, const GURL&, const std::string&, bool));

MOCK_METHOD3(ShowPhishingInterstitial,

void(const GURL&, const std::string&, content::WebContents*));

@@ -635,9 +635,9 @@ TEST_F(ChromePasswordManagerClientTest,

std::unique_ptr<MockChromePasswordManagerClient> client(

new MockChromePasswordManagerClient(test_web_contents.get()));

EXPECT_CALL(*client->password_protection_service(),

- MaybeStartProtectedPasswordEntryRequest(_, _, _))

+ MaybeStartProtectedPasswordEntryRequest(_, _, _, true))

.Times(1);

- client->CheckProtectedPasswordEntry(std::string("saved_domain.com"));

+ client->CheckProtectedPasswordEntry(std::string("saved_domain.com"), true);

}

#endif