components/safe_browsing/password_protection/password_protection_service.h - Issue 2929533002: Fill has_password_field for password reuse ping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing/password_protection/password_protection_service.h

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)

Patch Set: fix broken test due to rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/safe_browsing/password_protection/password_protection_request.cc ('k') | components/safe_browsing/password_protection/password_protection_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing/password_protection/password_protection_service.h

diff --git a/components/safe_browsing/password_protection/password_protection_service.h b/components/safe_browsing/password_protection/password_protection_service.h

index 4800ae9739fa5218cb7543626f299e8a033736a3..89870aa2361fb48d88ff1d648814d6b2f8f4d85e 100644

--- a/components/safe_browsing/password_protection/password_protection_service.h

+++ b/components/safe_browsing/password_protection/password_protection_service.h

@@ -106,7 +106,8 @@ class PasswordProtectionService : public history::HistoryServiceObserver {

const GURL& password_form_action,

const GURL& password_form_frame_url,

const std::string& saved_domain,

- LoginReputationClientRequest::TriggerType type);

+ LoginReputationClientRequest::TriggerType type,

+ bool password_field_exists);

virtual void MaybeStartPasswordFieldOnFocusRequest(

content::WebContents* web_contents,

@@ -117,7 +118,8 @@ class PasswordProtectionService : public history::HistoryServiceObserver {

virtual void MaybeStartProtectedPasswordEntryRequest(

content::WebContents* web_contents,

const GURL& main_frame_url,

- const std::string& saved_domain);

+ const std::string& saved_domain,

+ bool password_field_exists);

scoped_refptr<SafeBrowsingDatabaseManager> database_manager();