Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: components/safe_browsing/password_protection/password_protection_request.h

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)
Patch Set: fix broken test due to rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_request.h
diff --git a/components/safe_browsing/password_protection/password_protection_request.h b/components/safe_browsing/password_protection/password_protection_request.h
index 2bb4499ebd267c1ab1b16a65246d593c521d4f5f..721739b277ec9f29bfed6528591466b0edc95035 100644
--- a/components/safe_browsing/password_protection/password_protection_request.h
+++ b/components/safe_browsing/password_protection/password_protection_request.h
@@ -46,6 +46,7 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<
const GURL& password_form_frame_url,
const std::string& saved_domain,
LoginReputationClientRequest::TriggerType type,
+ bool password_field_exists,
PasswordProtectionService* pps,
int request_timeout_in_ms);
@@ -130,6 +131,9 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<
// If this request is for unfamiliar login page or for a password reuse event.
const LoginReputationClientRequest::TriggerType request_type_;
+ // If there is a password field on the page.
+ const bool password_field_exists_;
+
// When request is sent.
base::TimeTicks request_start_time_;

Powered by Google App Engine
This is Rietveld 408576698