Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dcheng, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, groby+blinkspell_chromium.org, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, mlamouri+watch-blink_chromium.org, Navid Zolghadr, pdr+renderingwatchlist_chromium.org, platform-architecture-syd+reviews-web_chromium.org, szager+layoutwatch_chromium.org, timvolodine, Xiaocheng, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename VisibleSelection::end() to End() This patch renames |VisibleSelection::end()| to |End()| to follow Blink coding style. BUG=727486 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2920733002 Cr-Commit-Position: refs/heads/master@{#476508} Committed: https://chromium.googlesource.com/chromium/src/+/48496eefc2ca8dc673daf4eff0d45a0822489ebf

Patch Set 1 : 2017-06-01T18:31:38 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -112 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/LayoutSelection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionModifier.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp View 10 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 4 chunks +8 lines, -7 lines 1 comment Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlerTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (15 generated)
yosin_UTC9
PTAL https://codereview.chromium.org/2920733002/diff/20001/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp File third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp (right): https://codereview.chromium.org/2920733002/diff/20001/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp#newcode397 third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp:397: IsMailHTMLBlockquoteElement)) { For pass PRESUBMIT
3 years, 6 months ago (2017-06-01 09:42:50 UTC) #10
tkent
lgtm
3 years, 6 months ago (2017-06-01 23:37:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920733002/20001
3 years, 6 months ago (2017-06-02 01:02:56 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 01:08:19 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48496eefc2ca8dc673daf4eff0d4...

Powered by Google App Engine
This is Rietveld 408576698