third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 2920733002: Rename VisibleSelection::end() to End()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)

Patch Set: 2017-06-01T18:31:38 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index ed27e3352eb15c2f9c6d50417f0d76d8e0854af3..801ba8f69807831a5ac0759ddcca72ce72deadb0 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -205,7 +205,7 @@ void InsertListCommand::DoApply(EditingState* editing_state) {

kCanSkipOverEditingBoundary)

.DeepEquivalent() != start_of_last_paragraph) {

force_list_creation =

- !SelectionHasListOfType(selection.Start(), selection.end(), list_tag);

+ !SelectionHasListOfType(selection.Start(), selection.End(), list_tag);

VisiblePosition start_of_current_paragraph = visible_start_of_selection;

while (InSameTreeAndOrdered(start_of_current_paragraph.DeepEquivalent(),