third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 2920733002: Rename VisibleSelection::end() to End()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)

Patch Set: 2017-06-01T18:31:38 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index 07af93b3a98a7d9c0cc7b6fd9a7fdac01e0d4598..b93ff4ef238d524bd01852baf72bd5b6191801a1 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -1028,8 +1028,8 @@ void ReplaceSelectionCommand::DoApply(EditingState* editing_state) {

->GetLayoutObject()

->Style()

->UserModify() == EUserModify::kReadWritePlaintextOnly) &&

- (selection.end().AnchorNode()->GetLayoutObject() &&

- selection.end().AnchorNode()->GetLayoutObject()->Style()->UserModify() ==

+ (selection.End().AnchorNode()->GetLayoutObject() &&

+ selection.End().AnchorNode()->GetLayoutObject()->Style()->UserModify() ==

EUserModify::kReadWritePlaintextOnly))

match_style_ = false;

@@ -1964,7 +1964,7 @@ bool ReplaceSelectionCommand::PerformTrivialReplace(

GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();

Node* node_after_insertion_pos =

- MostForwardCaretPosition(EndingSelection().end()).AnchorNode();

+ MostForwardCaretPosition(EndingSelection().End()).AnchorNode();

Text* text_node = ToText(fragment.FirstChild());

// Our fragment creation code handles tabs, spaces, and newlines, so we don't

// have to worry about those here.