third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp - Issue 2920733002: Rename VisibleSelection::end() to End()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)

Patch Set: 2017-06-01T18:31:38 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp b/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp

index 52cb1bfecd9355a523e7a3b7ccc0f915e7be36b8..f3862271b22c7239732751a531d631aac646da07 100644

--- a/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp

@@ -69,7 +69,7 @@ TEST_F(SelectionControllerTest, setNonDirectionalSelectionIfNeeded) {

EXPECT_EQ(Position(top, 1), VisibleSelectionInDOMTree().Base());

EXPECT_EQ(Position::BeforeNode(host), VisibleSelectionInDOMTree().Extent());

EXPECT_EQ(Position(top, 1), VisibleSelectionInDOMTree().Start());

- EXPECT_EQ(Position(top, 3), VisibleSelectionInDOMTree().end());

+ EXPECT_EQ(Position(top, 3), VisibleSelectionInDOMTree().End());

EXPECT_EQ(PositionInFlatTree(top, 1), GetVisibleSelectionInFlatTree().Base());

EXPECT_EQ(PositionInFlatTree(bottom, 3),

@@ -77,7 +77,7 @@ TEST_F(SelectionControllerTest, setNonDirectionalSelectionIfNeeded) {

EXPECT_EQ(PositionInFlatTree(top, 1),

GetVisibleSelectionInFlatTree().Start());

EXPECT_EQ(PositionInFlatTree(bottom, 3),

- GetVisibleSelectionInFlatTree().end());

+ GetVisibleSelectionInFlatTree().End());

// bottom to top

SetNonDirectionalSelectionIfNeeded(

@@ -90,7 +90,7 @@ TEST_F(SelectionControllerTest, setNonDirectionalSelectionIfNeeded) {

EXPECT_EQ(Position::BeforeNode(bottom->parentNode()),

VisibleSelectionInDOMTree().Extent());

EXPECT_EQ(Position(bottom, 0), VisibleSelectionInDOMTree().Start());

- EXPECT_EQ(Position(bottom, 3), VisibleSelectionInDOMTree().end());

+ EXPECT_EQ(Position(bottom, 3), VisibleSelectionInDOMTree().End());

EXPECT_EQ(PositionInFlatTree(bottom, 3),

GetVisibleSelectionInFlatTree().Base());

@@ -99,7 +99,7 @@ TEST_F(SelectionControllerTest, setNonDirectionalSelectionIfNeeded) {

EXPECT_EQ(PositionInFlatTree(top, 1),

GetVisibleSelectionInFlatTree().Start());

EXPECT_EQ(PositionInFlatTree(bottom, 3),

- GetVisibleSelectionInFlatTree().end());

+ GetVisibleSelectionInFlatTree().End());

}

TEST_F(SelectionControllerTest, setCaretAtHitTestResult) {