third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp - Issue 2920733002: Rename VisibleSelection::end() to End()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)

Patch Set: 2017-06-01T18:31:38 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp ('k') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

index d707fdeb0f21659b9b57ad781db1e1a3865d928f..b2cda7c3237226d6c3a149b7412e5424120e1bf2 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

@@ -118,7 +118,7 @@ ApplyStyleCommand::ApplyStyleCommand(Document& document,

input_type_(input_type),

property_level_(property_level),

start_(MostForwardCaretPosition(EndingSelection().Start())),

- end_(MostBackwardCaretPosition(EndingSelection().end())),

+ end_(MostBackwardCaretPosition(EndingSelection().End())),

use_ending_selection_(true),

styled_inline_element_(nullptr),

remove_only_(false),

@@ -145,7 +145,7 @@ ApplyStyleCommand::ApplyStyleCommand(Element* element, bool remove_only)

input_type_(InputEvent::InputType::kNone),

property_level_(kPropertyDefault),

start_(MostForwardCaretPosition(EndingSelection().Start())),

- end_(MostBackwardCaretPosition(EndingSelection().end())),

+ end_(MostBackwardCaretPosition(EndingSelection().End())),

use_ending_selection_(true),

styled_inline_element_(element),

remove_only_(remove_only),

@@ -161,7 +161,7 @@ ApplyStyleCommand::ApplyStyleCommand(

input_type_(input_type),

property_level_(kPropertyDefault),

start_(MostForwardCaretPosition(EndingSelection().Start())),

- end_(MostBackwardCaretPosition(EndingSelection().end())),

+ end_(MostBackwardCaretPosition(EndingSelection().End())),

use_ending_selection_(true),

styled_inline_element_(nullptr),

remove_only_(true),

@@ -193,7 +193,7 @@ Position ApplyStyleCommand::StartPosition() {

Position ApplyStyleCommand::EndPosition() {

if (use_ending_selection_)

- return EndingSelection().end();

+ return EndingSelection().End();

return end_;

}