third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp - Issue 2920733002: Rename VisibleSelection::end() to End()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)

Patch Set: 2017-06-01T18:31:38 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

index e803959aaee2f344fcc794d62bfc02d30ea125f5..0d7f811e1c06cc697bf79ab890429bd28dbc2533 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

@@ -106,7 +106,7 @@ bool InsertTextCommand::PerformTrivialReplace(const String& text,

if (select_inserted_text)

return true;

SetEndingSelection(SelectionInDOMTree::Builder()

- .Collapse(EndingSelection().end())

+ .Collapse(EndingSelection().End())

.SetIsDirectional(EndingSelection().IsDirectional())

.Build());

return true;

@@ -135,7 +135,7 @@ bool InsertTextCommand::PerformOverwrite(const String& text,

if (select_inserted_text || EndingSelection().IsNone())

return true;

SetEndingSelection(SelectionInDOMTree::Builder()

- .Collapse(EndingSelection().end())

+ .Collapse(EndingSelection().End())

.SetIsDirectional(EndingSelection().IsDirectional())

.Build());

return true;

@@ -287,8 +287,8 @@ void InsertTextCommand::DoApply(EditingState* editing_state) {

SelectionInDOMTree::Builder builder;

builder.SetAffinity(EndingSelection().Affinity());

builder.SetIsDirectional(EndingSelection().IsDirectional());

- if (EndingSelection().end().IsNotNull())

- builder.Collapse(EndingSelection().end());

+ if (EndingSelection().End().IsNotNull())

+ builder.Collapse(EndingSelection().End());

SetEndingSelection(builder.Build());

}