third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2920733002: Rename VisibleSelection::end() to End()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)

Patch Set: 2017-06-01T18:31:38 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index dbda1d3d4c9c363a16722380587c9f22bf2e4117..0f2b0884d68b49143006834b6c9c3508ec972fcf 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -549,7 +549,7 @@ void CompositeEditCommand::ReplaceTextInNode(Text* node,

Position CompositeEditCommand::ReplaceSelectedTextInNode(const String& text) {

Position start = EndingSelection().Start();

- Position end = EndingSelection().end();

+ Position end = EndingSelection().End();

if (start.ComputeContainerNode() != end.ComputeContainerNode() ||

!start.ComputeContainerNode()->IsTextNode() ||

IsTabHTMLSpanElementTextNode(start.ComputeContainerNode()))

@@ -780,7 +780,7 @@ void CompositeEditCommand::RebalanceWhitespace() {

RebalanceWhitespaceAt(selection.Start());

if (selection.IsRange())

- RebalanceWhitespaceAt(selection.end());

+ RebalanceWhitespaceAt(selection.End());

}

void CompositeEditCommand::DeleteInsignificantText(Text* text_node,