Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionModifier.cpp

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)
Patch Set: 2017-06-01T18:31:38 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionModifier.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionModifier.cpp b/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
index 27912020bec8208d53c87dc6d29a714e1b3b2b76..1f08e087577967e71f721b36225c456c5e7b9ddc 100644
--- a/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
@@ -138,8 +138,8 @@ static SelectionInDOMTree PrepareToExtendSeelction(
const bool base_is_start = IsBaseStart(visible_selection, direction);
return SelectionInDOMTree::Builder(visible_selection.AsSelection())
.Collapse(base_is_start ? visible_selection.Start()
- : visible_selection.end())
- .Extend(base_is_start ? visible_selection.end()
+ : visible_selection.End())
+ .Extend(base_is_start ? visible_selection.End()
: visible_selection.Start())
.Build();
}
@@ -289,7 +289,7 @@ VisiblePosition SelectionModifier::ModifyMovingRight(
CreateVisiblePosition(selection_.Extent(), selection_.Affinity()));
}
if (DirectionOfSelection() == TextDirection::kLtr)
- return CreateVisiblePosition(selection_.end(), selection_.Affinity());
+ return CreateVisiblePosition(selection_.End(), selection_.Affinity());
return CreateVisiblePosition(selection_.Start(), selection_.Affinity());
case kWordGranularity: {
const bool skips_space_when_moving_right =
@@ -322,7 +322,7 @@ VisiblePosition SelectionModifier::ModifyMovingForward(
switch (granularity) {
case kCharacterGranularity:
if (selection_.IsRange())
- pos = CreateVisiblePosition(selection_.end(), selection_.Affinity());
+ pos = CreateVisiblePosition(selection_.End(), selection_.Affinity());
else
pos = NextPositionOf(
CreateVisiblePosition(selection_.Extent(), selection_.Affinity()),
@@ -474,7 +474,7 @@ VisiblePosition SelectionModifier::ModifyMovingLeft(
}
if (DirectionOfSelection() == TextDirection::kLtr)
return CreateVisiblePosition(selection_.Start(), selection_.Affinity());
- return CreateVisiblePosition(selection_.end(), selection_.Affinity());
+ return CreateVisiblePosition(selection_.End(), selection_.Affinity());
case kWordGranularity: {
const bool skips_space_when_moving_right =
GetFrame() &&
@@ -727,7 +727,7 @@ bool SelectionModifier::ModifyWithPageGranularity(EAlteration alter,
case FrameSelection::kAlterationMove:
pos = CreateVisiblePosition(direction == FrameSelection::kDirectionUp
? selection_.Start()
- : selection_.end(),
+ : selection_.End(),
selection_.Affinity());
x_pos = LineDirectionPointForBlockDirectionNavigation(
direction == FrameSelection::kDirectionUp ? START : END);
@@ -837,7 +837,7 @@ LayoutUnit SelectionModifier::LineDirectionPointForBlockDirectionNavigation(
pos = selection_.Start();
break;
case END:
- pos = selection_.end();
+ pos = selection_.End();
break;
case BASE:
pos = selection_.Base();

Powered by Google App Engine
This is Rietveld 408576698