Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)
Patch Set: 2017-06-01T18:31:38 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index e3f650ec241b54c203497dd8219f0677e3a41f48..0d2f1033ee17b2221b1f2042e9a5589473e91d9e 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -140,7 +140,7 @@ EphemeralRange FirstEphemeralRangeOf(const VisibleSelection& selection) {
if (selection.IsNone())
return EphemeralRange();
Position start = selection.Start().ParentAnchoredEquivalent();
- Position end = selection.end().ParentAnchoredEquivalent();
+ Position end = selection.End().ParentAnchoredEquivalent();
return EphemeralRange(start, end);
}
@@ -686,7 +686,7 @@ static bool EqualSelectionsAlgorithm(
const VisibleSelectionTemplate<Strategy> selection_wrapper2(selection2);
return selection_wrapper1.Start() == selection_wrapper2.Start() &&
- selection_wrapper1.end() == selection_wrapper2.end() &&
+ selection_wrapper1.End() == selection_wrapper2.End() &&
selection_wrapper1.Base() == selection_wrapper2.Base() &&
selection_wrapper1.Extent() == selection_wrapper2.Extent();
}
@@ -715,12 +715,12 @@ void VisibleSelectionTemplate<Strategy>::ShowTreeForThis() const {
<< Start()
.AnchorNode()
->ToMarkedTreeString(Start().AnchorNode(), "S",
- end().AnchorNode(), "E")
+ End().AnchorNode(), "E")
.Utf8()
.data()
<< "start: " << Start().ToAnchorTypeAndOffsetString().Utf8().data()
<< "\n"
- << "end: " << end().ToAnchorTypeAndOffsetString().Utf8().data();
+ << "end: " << End().ToAnchorTypeAndOffsetString().Utf8().data();
}
#endif
@@ -735,7 +735,7 @@ void VisibleSelectionTemplate<Strategy>::PrintTo(
}
*ostream << "VisibleSelection(base: " << selection.Base()
<< " extent:" << selection.Extent()
- << " start: " << selection.Start() << " end: " << selection.end()
+ << " start: " << selection.Start() << " end: " << selection.End()
<< ' ' << selection.Affinity() << ' '
<< (selection.IsDirectional() ? "Directional" : "NonDirectional")
<< ')';

Powered by Google App Engine
This is Rietveld 408576698