third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2920733002: Rename VisibleSelection::end() to End()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)

Patch Set: 2017-06-01T18:31:38 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index 459034657393d31623397c0c3fd4915dd4814736..cd7eee62db88beb3231996e948d18f3050e10848 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -1598,7 +1598,7 @@ bool Editor::FindString(const String& target, FindOptions options) {

// TODO(yosin) We should make |findRangeOfString()| to return

// |EphemeralRange| rather than|Range| object.

Range* result_range = FindRangeOfString(

- target, EphemeralRange(selection.Start(), selection.end()),

+ target, EphemeralRange(selection.Start(), selection.End()),

static_cast<FindOptions>(options | kFindAPICall));

if (!result_range)