Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)
Patch Set: 2017-06-01T18:31:38 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 881 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 return; 892 return;
893 if (before == 0) 893 if (before == 0)
894 break; 894 break;
895 ++before; 895 ++before;
896 } while (GetFrame() 896 } while (GetFrame()
897 .Selection() 897 .Selection()
898 .ComputeVisibleSelectionInDOMTreeDeprecated() 898 .ComputeVisibleSelectionInDOMTreeDeprecated()
899 .Start() == GetFrame() 899 .Start() == GetFrame()
900 .Selection() 900 .Selection()
901 .ComputeVisibleSelectionInDOMTreeDeprecated() 901 .ComputeVisibleSelectionInDOMTreeDeprecated()
902 .end() && 902 .End() &&
903 before <= static_cast<int>(selection_offsets.Start())); 903 before <= static_cast<int>(selection_offsets.Start()));
904 // TODO(chongz): Find a way to distinguish Forward and Backward. 904 // TODO(chongz): Find a way to distinguish Forward and Backward.
905 Node* target = GetDocument().FocusedElement(); 905 Node* target = GetDocument().FocusedElement();
906 if (target) { 906 if (target) {
907 DispatchBeforeInputEditorCommand( 907 DispatchBeforeInputEditorCommand(
908 target, InputEvent::InputType::kDeleteContentBackward, 908 target, InputEvent::InputType::kDeleteContentBackward,
909 TargetRangesForInputEvent(*target)); 909 TargetRangesForInputEvent(*target));
910 } 910 }
911 TypingCommand::DeleteSelection(GetDocument()); 911 TypingCommand::DeleteSelection(GetDocument());
912 } 912 }
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
1235 FinishComposingText(kKeepSelection); 1235 FinishComposingText(kKeepSelection);
1236 } 1236 }
1237 1237
1238 DEFINE_TRACE(InputMethodController) { 1238 DEFINE_TRACE(InputMethodController) {
1239 visitor->Trace(frame_); 1239 visitor->Trace(frame_);
1240 visitor->Trace(composition_range_); 1240 visitor->Trace(composition_range_);
1241 SynchronousMutationObserver::Trace(visitor); 1241 SynchronousMutationObserver::Trace(visitor);
1242 } 1242 }
1243 1243
1244 } // namespace blink 1244 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698