Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2920733002: Rename VisibleSelection::end() to End() (Closed)
Patch Set: 2017-06-01T18:31:38 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h
index 37d60f7eff87dd654b71daf32c2f7ca55aaa3df4..11a85d062b961274345968ba76425487819348b6 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h
@@ -69,7 +69,7 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
PositionTemplate<Strategy> Base() const { return base_; }
PositionTemplate<Strategy> Extent() const { return extent_; }
PositionTemplate<Strategy> Start() const { return start_; }
- PositionTemplate<Strategy> end() const { return end_; }
+ PositionTemplate<Strategy> End() const { return end_; }
VisiblePositionTemplate<Strategy> VisibleStart() const {
return CreateVisiblePosition(
@@ -101,10 +101,10 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
bool IsCaret() const { return GetSelectionType() == kCaretSelection; }
bool IsRange() const { return GetSelectionType() == kRangeSelection; }
bool IsNonOrphanedRange() const {
- return IsRange() && !Start().IsOrphan() && !end().IsOrphan();
+ return IsRange() && !Start().IsOrphan() && !End().IsOrphan();
}
bool IsNonOrphanedCaretOrRange() const {
- return !IsNone() && !Start().IsOrphan() && !end().IsOrphan();
+ return !IsNone() && !Start().IsOrphan() && !End().IsOrphan();
}
// True if base() <= extent().

Powered by Google App Engine
This is Rietveld 408576698