Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2863593004: Remove the non-driver versions of several tests (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+561 lines, -911 lines) Patch
M pkg/analysis_server/test/analysis/get_navigation_test.dart View 5 chunks +15 lines, -26 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 4 chunks +2 lines, -26 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart View 4 chunks +2 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 4 chunks +3 lines, -17 lines 0 comments Download
D pkg/analysis_server/test/context_manager_driver_test.dart View 1 chunk +0 lines, -106 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 7 chunks +31 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 3 chunks +2 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 3 chunks +6 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 3 chunks +170 lines, -174 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/field_formal_contributor_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart View 4 chunks +51 lines, -62 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/inherited_reference_contributor_test.dart View 3 chunks +27 lines, -31 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/label_contributor_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/library_member_contributor_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/library_prefix_contributor_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart View 3 chunks +20 lines, -25 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_library_contributor_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 3 chunks +76 lines, -81 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart View 2 chunks +3 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/static_member_contributor_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/type_member_contributor_test.dart View 3 chunks +58 lines, -62 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart View 3 chunks +4 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/variable_name_contributor_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 4 chunks +6 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 5 chunks +6 lines, -28 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_label_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 3 chunks +10 lines, -41 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Sorry about the size. Hopefully it's fairly straightforward to review, but if you'd like it ...
3 years, 7 months ago (2017-05-05 20:28:38 UTC) #2
scheglov
LGTM!
3 years, 7 months ago (2017-05-05 20:33:58 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-05 20:46:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
863bd921e16c31c4601605ab9f1864f2e9638ffe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698