Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart
index 04fe5d5848df91a333b75d915e854d7e7808e7af..6a71b69d401a676486359282a55cae6aca15c676 100644
--- a/pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart
@@ -14,12 +14,14 @@ import 'completion_contributor_util.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(LocalConstructorContributorTest);
- defineReflectiveTests(LocalConstructorContributorTest_Driver);
});
}
@reflectiveTest
class LocalConstructorContributorTest extends DartCompletionContributorTest {
+ @override
+ bool get enableNewAnalysisDriver => true;
+
CompletionSuggestion assertSuggestLocalVariable(
String name, String returnType,
{int relevance: DART_RELEVANCE_LOCAL_VARIABLE}) {
@@ -57,6 +59,23 @@ class LocalConstructorContributorTest extends DartCompletionContributorTest {
return new LocalConstructorContributor();
}
+ /// Sanity check. Permutations tested in local_ref_contributor.
+ test_ArgDefaults_cons_with_required_named() async {
+ addMetaPackageSource();
+ addTestSource('''
+import 'package:meta/meta.dart';
+
+class A {
+ A(int bar, {bool boo, @required int baz});
+ baz() {
+ new A^
+ }
+}''');
+ await computeSuggestions();
+
+ assertSuggestConstructor('A', defaultArgListString: 'bar, baz: null');
+ }
+
test_ArgumentList() async {
// ArgumentList MethodInvocation ExpressionStatement Block
addSource(
@@ -4142,27 +4161,3 @@ class C {bar(){var f; {var x;} var e = ^ var g}}''');
assertNotSuggested('e');
}
}
-
-@reflectiveTest
-class LocalConstructorContributorTest_Driver
- extends LocalConstructorContributorTest {
- @override
- bool get enableNewAnalysisDriver => true;
-
- /// Sanity check. Permutations tested in local_ref_contributor.
- test_ArgDefaults_cons_with_required_named() async {
- addMetaPackageSource();
- addTestSource('''
-import 'package:meta/meta.dart';
-
-class A {
- A(int bar, {bool boo, @required int baz});
- baz() {
- new A^
- }
-}''');
- await computeSuggestions();
-
- assertSuggestConstructor('A', defaultArgListString: 'bar, baz: null');
- }
-}

Powered by Google App Engine
This is Rietveld 408576698