Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
index 2509c411015c5f617ed753047e7ea4299d556661..00a5a716c21017c65b71312bb6245f45e3ea71f4 100644
--- a/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
@@ -14,12 +14,14 @@ import 'completion_contributor_util.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(LocalReferenceContributorTest);
- defineReflectiveTests(LocalReferenceContributorTest_Driver);
});
}
@reflectiveTest
class LocalReferenceContributorTest extends DartCompletionContributorTest {
+ @override
+ bool get enableNewAnalysisDriver => true;
+
CompletionSuggestion assertSuggestLocalVariable(
String name, String returnType,
{int relevance: DART_RELEVANCE_LOCAL_VARIABLE}) {
@@ -57,6 +59,79 @@ class LocalReferenceContributorTest extends DartCompletionContributorTest {
return new LocalReferenceContributor();
}
+ test_ArgDefaults_function() async {
+ addTestSource('''
+bool hasLength(int a, bool b) => false;
+void main() {h^}''');
+ await computeSuggestions();
+
+ assertSuggestFunction('hasLength', 'bool',
+ relevance: DART_RELEVANCE_LOCAL_FUNCTION,
+ defaultArgListString: 'a, b',
+ defaultArgumentListTextRanges: [0, 1, 3, 1]);
+ }
+
+ test_ArgDefaults_function_none() async {
+ addTestSource('''
+bool hasLength() => false;
+void main() {h^}''');
+ await computeSuggestions();
+
+ assertSuggestFunction('hasLength', 'bool',
+ relevance: DART_RELEVANCE_LOCAL_FUNCTION,
+ defaultArgListString: null,
+ defaultArgumentListTextRanges: null);
+ }
+
+ test_ArgDefaults_function_with_optional_positional() async {
+ addMetaPackageSource();
+ addTestSource('''
+import 'package:meta/meta.dart';
+
+bool foo(int bar, [bool boo, int baz]) => false;
+void main() {h^}''');
+ await computeSuggestions();
+
+ assertSuggestFunction('foo', 'bool',
+ relevance: DART_RELEVANCE_LOCAL_FUNCTION,
+ defaultArgListString: 'bar',
+ defaultArgumentListTextRanges: [0, 3]);
+ }
+
+ test_ArgDefaults_function_with_required_named() async {
+ addMetaPackageSource();
+ addTestSource('''
+import 'package:meta/meta.dart';
+
+bool foo(int bar, {bool boo, @required int baz}) => false;
+void main() {h^}''');
+ await computeSuggestions();
+
+ assertSuggestFunction('foo', 'bool',
+ relevance: DART_RELEVANCE_LOCAL_FUNCTION,
+ defaultArgListString: 'bar, baz: null',
+ defaultArgumentListTextRanges: [0, 3, 10, 4]);
+ }
+
+ test_ArgDefaults_method_with_required_named() async {
+ addMetaPackageSource();
+ addTestSource('''
+import 'package:meta/meta.dart';
+
+class A {
+ bool foo(int bar, {bool boo, @required int baz}) => false;
+ baz() {
+ f^
+ }
+}''');
+ await computeSuggestions();
+
+ assertSuggestMethod('foo', 'A', 'bool',
+ relevance: DART_RELEVANCE_LOCAL_METHOD,
+ defaultArgListString: 'bar, baz: null',
+ defaultArgumentListTextRanges: [0, 3, 10, 4]);
+ }
+
test_ArgumentList() async {
// ArgumentList MethodInvocation ExpressionStatement Block
addSource(
@@ -4586,83 +4661,3 @@ class C {bar(){var f; {var x;} var e = ^ var g}}''');
assertNotSuggested('e');
}
}
-
-@reflectiveTest
-class LocalReferenceContributorTest_Driver
- extends LocalReferenceContributorTest {
- @override
- bool get enableNewAnalysisDriver => true;
-
- test_ArgDefaults_function() async {
- addTestSource('''
-bool hasLength(int a, bool b) => false;
-void main() {h^}''');
- await computeSuggestions();
-
- assertSuggestFunction('hasLength', 'bool',
- relevance: DART_RELEVANCE_LOCAL_FUNCTION,
- defaultArgListString: 'a, b',
- defaultArgumentListTextRanges: [0, 1, 3, 1]);
- }
-
- test_ArgDefaults_function_none() async {
- addTestSource('''
-bool hasLength() => false;
-void main() {h^}''');
- await computeSuggestions();
-
- assertSuggestFunction('hasLength', 'bool',
- relevance: DART_RELEVANCE_LOCAL_FUNCTION,
- defaultArgListString: null,
- defaultArgumentListTextRanges: null);
- }
-
- test_ArgDefaults_function_with_optional_positional() async {
- addMetaPackageSource();
- addTestSource('''
-import 'package:meta/meta.dart';
-
-bool foo(int bar, [bool boo, int baz]) => false;
-void main() {h^}''');
- await computeSuggestions();
-
- assertSuggestFunction('foo', 'bool',
- relevance: DART_RELEVANCE_LOCAL_FUNCTION,
- defaultArgListString: 'bar',
- defaultArgumentListTextRanges: [0, 3]);
- }
-
- test_ArgDefaults_function_with_required_named() async {
- addMetaPackageSource();
- addTestSource('''
-import 'package:meta/meta.dart';
-
-bool foo(int bar, {bool boo, @required int baz}) => false;
-void main() {h^}''');
- await computeSuggestions();
-
- assertSuggestFunction('foo', 'bool',
- relevance: DART_RELEVANCE_LOCAL_FUNCTION,
- defaultArgListString: 'bar, baz: null',
- defaultArgumentListTextRanges: [0, 3, 10, 4]);
- }
-
- test_ArgDefaults_method_with_required_named() async {
- addMetaPackageSource();
- addTestSource('''
-import 'package:meta/meta.dart';
-
-class A {
- bool foo(int bar, {bool boo, @required int baz}) => false;
- baz() {
- f^
- }
-}''');
- await computeSuggestions();
-
- assertSuggestMethod('foo', 'A', 'bool',
- relevance: DART_RELEVANCE_LOCAL_METHOD,
- defaultArgListString: 'bar, baz: null',
- defaultArgumentListTextRanges: [0, 3, 10, 4]);
- }
-}

Powered by Google App Engine
This is Rietveld 408576698