Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Side by Side Diff: pkg/analysis_server/test/services/refactoring/rename_library_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:analysis_server/protocol/protocol_generated.dart'; 5 import 'package:analysis_server/protocol/protocol_generated.dart';
6 import 'package:analyzer/src/generated/source.dart'; 6 import 'package:analyzer/src/generated/source.dart';
7 import 'package:test/test.dart'; 7 import 'package:test/test.dart';
8 import 'package:test_reflective_loader/test_reflective_loader.dart'; 8 import 'package:test_reflective_loader/test_reflective_loader.dart';
9 9
10 import 'abstract_rename.dart'; 10 import 'abstract_rename.dart';
11 11
12 main() { 12 main() {
13 defineReflectiveSuite(() { 13 defineReflectiveSuite(() {
14 defineReflectiveTests(RenameLibraryTest); 14 defineReflectiveTests(RenameLibraryTest);
15 defineReflectiveTests(RenameLibraryTest_Driver);
16 }); 15 });
17 } 16 }
18 17
19 @reflectiveTest 18 @reflectiveTest
20 class RenameLibraryTest extends RenameRefactoringTest { 19 class RenameLibraryTest extends RenameRefactoringTest {
20 @override
21 bool get enableNewAnalysisDriver => true;
22
21 test_checkNewName() async { 23 test_checkNewName() async {
22 await indexTestUnit(''' 24 await indexTestUnit('''
23 library my.app; 25 library my.app;
24 '''); 26 ''');
25 _createRenameRefactoring(); 27 _createRenameRefactoring();
26 // null 28 // null
27 refactoring.newName = null; 29 refactoring.newName = null;
28 assertRefactoringStatus( 30 assertRefactoringStatus(
29 refactoring.checkNewName(), RefactoringProblemSeverity.FATAL, 31 refactoring.checkNewName(), RefactoringProblemSeverity.FATAL,
30 expectedMessage: "Library name must not be null."); 32 expectedMessage: "Library name must not be null.");
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 '/part.dart', 100 '/part.dart',
99 ''' 101 '''
100 part of the.new.name; 102 part of the.new.name;
101 '''); 103 ''');
102 } 104 }
103 105
104 void _createRenameRefactoring() { 106 void _createRenameRefactoring() {
105 createRenameRefactoringForElement(testUnitElement.library); 107 createRenameRefactoringForElement(testUnitElement.library);
106 } 108 }
107 } 109 }
108
109 @reflectiveTest
110 class RenameLibraryTest_Driver extends RenameLibraryTest {
111 @override
112 bool get enableNewAnalysisDriver => true;
113 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698