Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart
index c476fea29236ba72f0421d22d9f979b053f777c7..cfed83c955ed0855d304c86ae8820ab060e0d453 100644
--- a/pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart
@@ -16,14 +16,15 @@ main() {
defineReflectiveSuite(() {
defineReflectiveTests(UriContributorTest);
defineReflectiveTests(UriContributorWindowsTest);
- defineReflectiveTests(UriContributorTest_Driver);
- defineReflectiveTests(UriContributorWindowsTest_Driver);
});
}
@reflectiveTest
class UriContributorTest extends DartCompletionContributorTest {
@override
+ bool get enableNewAnalysisDriver => true;
+
+ @override
DartCompletionContributor createContributor() {
return new UriContributor();
}
@@ -463,13 +464,10 @@ class UriContributorTest extends DartCompletionContributorTest {
}
@reflectiveTest
-class UriContributorTest_Driver extends UriContributorTest {
+class UriContributorWindowsTest extends DartCompletionContributorTest {
@override
bool get enableNewAnalysisDriver => true;
-}
-@reflectiveTest
-class UriContributorWindowsTest extends DartCompletionContributorTest {
@override
DartCompletionContributor createContributor() {
return new UriContributor();
@@ -634,12 +632,6 @@ class UriContributorWindowsTest extends DartCompletionContributorTest {
}
}
-@reflectiveTest
-class UriContributorWindowsTest_Driver extends UriContributorWindowsTest {
- @override
- bool get enableNewAnalysisDriver => true;
-}
-
class _TestWinResourceProvider extends MemoryResourceProvider {
@override
Context get pathContext => windows;

Powered by Google App Engine
This is Rietveld 408576698