Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Side by Side Diff: pkg/analysis_server/test/services/refactoring/rename_import_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:analysis_server/protocol/protocol_generated.dart'; 5 import 'package:analysis_server/protocol/protocol_generated.dart';
6 import 'package:analyzer/dart/ast/ast.dart'; 6 import 'package:analyzer/dart/ast/ast.dart';
7 import 'package:test/test.dart'; 7 import 'package:test/test.dart';
8 import 'package:test_reflective_loader/test_reflective_loader.dart'; 8 import 'package:test_reflective_loader/test_reflective_loader.dart';
9 9
10 import 'abstract_rename.dart'; 10 import 'abstract_rename.dart';
11 11
12 main() { 12 main() {
13 defineReflectiveSuite(() { 13 defineReflectiveSuite(() {
14 defineReflectiveTests(RenameImportTest); 14 defineReflectiveTests(RenameImportTest);
15 defineReflectiveTests(RenameImportTest_Driver);
16 }); 15 });
17 } 16 }
18 17
19 @reflectiveTest 18 @reflectiveTest
20 class RenameImportTest extends RenameRefactoringTest { 19 class RenameImportTest extends RenameRefactoringTest {
20 @override
21 bool get enableNewAnalysisDriver => true;
22
21 test_checkNewName() async { 23 test_checkNewName() async {
22 await indexTestUnit("import 'dart:async' as test;"); 24 await indexTestUnit("import 'dart:async' as test;");
23 _createRefactoring("import 'dart:"); 25 _createRefactoring("import 'dart:");
24 expect(refactoring.oldName, 'test'); 26 expect(refactoring.oldName, 'test');
25 // null 27 // null
26 refactoring.newName = null; 28 refactoring.newName = null;
27 assertRefactoringStatus( 29 assertRefactoringStatus(
28 refactoring.checkNewName(), RefactoringProblemSeverity.FATAL, 30 refactoring.checkNewName(), RefactoringProblemSeverity.FATAL,
29 expectedMessage: "Import prefix name must not be null."); 31 expectedMessage: "Import prefix name must not be null.");
30 // same 32 // same
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 expect(refactoring.refactoringName, 'Rename Import Prefix'); 224 expect(refactoring.refactoringName, 'Rename Import Prefix');
223 expect(refactoring.oldName, ''); 225 expect(refactoring.oldName, '');
224 } 226 }
225 227
226 void _createRefactoring(String search) { 228 void _createRefactoring(String search) {
227 ImportDirective directive = 229 ImportDirective directive =
228 findNodeAtString(search, (node) => node is ImportDirective); 230 findNodeAtString(search, (node) => node is ImportDirective);
229 createRenameRefactoringForElement(directive.element); 231 createRenameRefactoringForElement(directive.element);
230 } 232 }
231 } 233 }
232
233 @reflectiveTest
234 class RenameImportTest_Driver extends RenameImportTest {
235 @override
236 bool get enableNewAnalysisDriver => true;
237 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698