Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:analysis_server/protocol/protocol_generated.dart'; 5 import 'package:analysis_server/protocol/protocol_generated.dart';
6 import 'package:analysis_server/src/services/correction/status.dart'; 6 import 'package:analysis_server/src/services/correction/status.dart';
7 import 'package:test/test.dart'; 7 import 'package:test/test.dart';
8 import 'package:test_reflective_loader/test_reflective_loader.dart'; 8 import 'package:test_reflective_loader/test_reflective_loader.dart';
9 9
10 import 'abstract_rename.dart'; 10 import 'abstract_rename.dart';
11 11
12 main() { 12 main() {
13 defineReflectiveSuite(() { 13 defineReflectiveSuite(() {
14 defineReflectiveTests(RenameUnitMemberTest); 14 defineReflectiveTests(RenameUnitMemberTest);
15 defineReflectiveTests(RenameUnitMemberTest_Driver);
16 }); 15 });
17 } 16 }
18 17
19 @reflectiveTest 18 @reflectiveTest
20 class RenameUnitMemberTest extends RenameRefactoringTest { 19 class RenameUnitMemberTest extends RenameRefactoringTest {
20 @override
21 bool get enableNewAnalysisDriver => true;
22
21 test_checkFinalConditions_hasTopLevel_ClassElement() async { 23 test_checkFinalConditions_hasTopLevel_ClassElement() async {
22 await indexTestUnit(''' 24 await indexTestUnit('''
23 class Test {} 25 class Test {}
24 class NewName {} // existing 26 class NewName {} // existing
25 '''); 27 ''');
26 createRenameRefactoringAtString('Test {}'); 28 createRenameRefactoringAtString('Test {}');
27 // check status 29 // check status
28 refactoring.newName = 'NewName'; 30 refactoring.newName = 'NewName';
29 RefactoringStatus status = await refactoring.checkFinalConditions(); 31 RefactoringStatus status = await refactoring.checkFinalConditions();
30 assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR, 32 assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
(...skipping 584 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 return assertSuccessfulRefactoring(''' 617 return assertSuccessfulRefactoring('''
616 int newName = 0; 618 int newName = 0;
617 main() { 619 main() {
618 print(newName); 620 print(newName);
619 newName = 1; 621 newName = 1;
620 newName += 2; 622 newName += 2;
621 } 623 }
622 '''); 624 ''');
623 } 625 }
624 } 626 }
625
626 @reflectiveTest
627 class RenameUnitMemberTest_Driver extends RenameUnitMemberTest {
628 @override
629 bool get enableNewAnalysisDriver => true;
630 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698