Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: pkg/analysis_server/test/context_manager_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/context_manager_test.dart
diff --git a/pkg/analysis_server/test/context_manager_test.dart b/pkg/analysis_server/test/context_manager_test.dart
index 96db4e210cede7d0cd2554b2b9bb97677662aeee..e7370be34011997a9802ab337a1643cda97f2767 100644
--- a/pkg/analysis_server/test/context_manager_test.dart
+++ b/pkg/analysis_server/test/context_manager_test.dart
@@ -49,6 +49,8 @@ main() {
@reflectiveTest
class AbstractContextManagerTest extends ContextManagerTest {
+ bool get enableAnalysisDriver => true;
+
void test_contextsInAnalysisRoot_nestedContext() {
String subProjPath = path.posix.join(projPath, 'subproj');
Folder subProjFolder = resourceProvider.newFolder(subProjPath);
@@ -87,7 +89,17 @@ class AbstractContextManagerTest extends ContextManagerTest {
}
}
+ @failingTest
test_embedder_added() async {
+ // NoSuchMethodError: The getter 'apiSignature' was called on null.
+ // Receiver: null
+ // Tried calling: apiSignature
+ // dart:core Object.noSuchMethod
+ // package:analyzer/src/dart/analysis/driver.dart 460:20 AnalysisDriver.configure
+ // package:analysis_server/src/context_manager.dart 1043:16 ContextManagerImpl._checkForPackagespecUpdate
+ // package:analysis_server/src/context_manager.dart 1553:5 ContextManagerImpl._handleWatchEvent
+ //return super.test_embedder_added();
+ fail('NoSuchMethodError');
// Create files.
String libPath = newFolder([projPath, ContextManagerTest.LIB_NAME]);
newFile([libPath, 'main.dart']);
@@ -1890,11 +1902,15 @@ abstract class ContextManagerTest {
@reflectiveTest
class ContextManagerWithNewOptionsTest extends ContextManagerWithOptionsTest {
+ bool get enableAnalysisDriver => true;
+
String get optionsFileName => AnalysisEngine.ANALYSIS_OPTIONS_YAML_FILE;
}
@reflectiveTest
class ContextManagerWithOldOptionsTest extends ContextManagerWithOptionsTest {
+ bool get enableAnalysisDriver => true;
+
String get optionsFileName => AnalysisEngine.ANALYSIS_OPTIONS_FILE;
}
@@ -1937,7 +1953,10 @@ linter:
expect(analysisOptions.enableStrictCallChecks, isFalse);
}
+ @failingTest
test_analysis_options_file_delete_with_embedder() async {
+ // This fails because the ContextBuilder doesn't pick up the strongMode
+ // flag from the embedder.yaml file.
// Setup _embedder.yaml.
String libPath = newFolder([projPath, ContextManagerTest.LIB_NAME]);
newFile(
@@ -2103,7 +2122,10 @@ include: package:boo/other_options.yaml
await pumpEventQueue();
}
+ @failingTest
test_embedder_options() async {
+ // This fails because the ContextBuilder doesn't pick up the strongMode
+ // flag from the embedder.yaml file.
// Create files.
String libPath = newFolder([projPath, ContextManagerTest.LIB_NAME]);
String sdkExtPath = newFolder([projPath, 'sdk_ext']);
@@ -2266,7 +2288,14 @@ analyzer:
expect(errorProcessors, isEmpty);
}
+ @failingTest
test_optionsFile_update_strongMode() async {
+ // It appears that this fails because we are not correctly updating the
+ // analysis options in the driver when the file is modified.
+ //return super.test_optionsFile_update_strongMode();
+ // After a few other changes, the test now times out on my machine, so I'm
+ // disabling it in order to prevent it from being flaky.
+ fail('Test times out');
var file = resourceProvider.newFile(
'$projPath/bin/test.dart',
r'''
@@ -2339,7 +2368,9 @@ analyzer:
}
}
+ @failingTest
test_path_filter_analysis_option() async {
+ // This fails because we're not analyzing the analysis options file.
// Create files.
String libPath = newFolder([projPath, ContextManagerTest.LIB_NAME]);
newFile([libPath, 'main.dart']);
« no previous file with comments | « pkg/analysis_server/test/context_manager_driver_test.dart ('k') | pkg/analysis_server/test/domain_diagnostic_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698