Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: pkg/analysis_server/test/analysis/notification_errors_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/notification_errors_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_errors_test.dart b/pkg/analysis_server/test/analysis/notification_errors_test.dart
index f3fbcaea226a5ed9e7e7b36c0229a929dee887c0..7f1414005eff2e95b19c58de877dfcc13f324cb8 100644
--- a/pkg/analysis_server/test/analysis/notification_errors_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_errors_test.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library test.analysis.notification_errors;
-
import 'package:analysis_server/protocol/protocol.dart';
import 'package:analysis_server/protocol/protocol_generated.dart';
import 'package:analysis_server/src/constants.dart';
@@ -23,12 +21,11 @@ import '../mocks.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(NotificationErrorsTest);
- defineReflectiveTests(NotificationErrorsTest_Driver);
});
}
@reflectiveTest
-class AbstractNotificationErrorsTest extends AbstractAnalysisTest {
+class NotificationErrorsTest extends AbstractAnalysisTest {
Map<String, List<AnalysisError>> filesErrors = {};
void processNotification(Notification notification) {
@@ -40,6 +37,8 @@ class AbstractNotificationErrorsTest extends AbstractAnalysisTest {
@override
void setUp() {
+ enableNewAnalysisDriver = true;
+ generateSummaryFiles = true;
registerLintRules();
super.setUp();
server.handlers = [
@@ -153,16 +152,3 @@ main() {
expect(error.type, AnalysisErrorType.STATIC_WARNING);
}
}
-
-@reflectiveTest
-class NotificationErrorsTest extends AbstractNotificationErrorsTest {}
-
-@reflectiveTest
-class NotificationErrorsTest_Driver extends AbstractNotificationErrorsTest {
- @override
- void setUp() {
- enableNewAnalysisDriver = true;
- generateSummaryFiles = true;
- super.setUp();
- }
-}

Powered by Google App Engine
This is Rietveld 408576698