Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: pkg/analysis_server/test/analysis/notification_analysis_options_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart b/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
index 97e7094155e8a34a5727918bca4efb09c77ad204..5a57e2b814f88af7847dfac5003187bdfa4cb5ca 100644
--- a/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library test.analysis.notification_analysis_options_test;
-
import 'package:analysis_server/protocol/protocol.dart';
import 'package:analysis_server/protocol/protocol_generated.dart'
hide AnalysisOptions;
@@ -21,8 +19,6 @@ main() {
defineReflectiveSuite(() {
defineReflectiveTests(NewAnalysisOptionsFileNotificationTest);
defineReflectiveTests(OldAnalysisOptionsFileNotificationTest);
- defineReflectiveTests(NewAnalysisOptionsFileNotificationTest_Driver);
- defineReflectiveTests(OldAnalysisOptionsFileNotificationTest_Driver);
});
}
@@ -76,6 +72,8 @@ analyzer:
@override
void setUp() {
+ enableNewAnalysisDriver = true;
+ generateSummaryFiles = true;
registerLintRules();
super.setUp();
server.handlers = [new AnalysisDomainHandler(server)];
@@ -340,30 +338,8 @@ class NewAnalysisOptionsFileNotificationTest
}
@reflectiveTest
-class NewAnalysisOptionsFileNotificationTest_Driver
- extends NewAnalysisOptionsFileNotificationTest {
- @override
- void setUp() {
- enableNewAnalysisDriver = true;
- generateSummaryFiles = true;
- super.setUp();
- }
-}
-
-@reflectiveTest
class OldAnalysisOptionsFileNotificationTest
extends AnalysisOptionsFileNotificationTest {
@override
String get optionsFilePath => '$projectPath/.analysis_options';
}
-
-@reflectiveTest
-class OldAnalysisOptionsFileNotificationTest_Driver
- extends OldAnalysisOptionsFileNotificationTest {
- @override
- void setUp() {
- enableNewAnalysisDriver = true;
- generateSummaryFiles = true;
- super.setUp();
- }
-}

Powered by Google App Engine
This is Rietveld 408576698