pkg/analysis_server/test/context_manager_driver_test.dart - Issue 2863593004: Remove the non-driver versions of several tests

Side by Side Diff: pkg/analysis_server/test/context_manager_driver_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.

4

5 import 'package:test/test.dart';

6 import 'package:test_reflective_loader/test_reflective_loader.dart';

7

8 import 'context_manager_test.dart';

9

10 main() {

11 defineReflectiveSuite(() {

12 defineReflectiveTests(AbstractContextManagerTest_Driver);

13 defineReflectiveTests(ContextManagerWithNewOptionsTest_Driver);

14 defineReflectiveTests(ContextManagerWithOldOptionsTest_Driver);

15 });

16 }

17

18 @reflectiveTest

19 class AbstractContextManagerTest_Driver extends AbstractContextManagerTest {

20 bool get enableAnalysisDriver => true;

21

22 @failingTest

23 test_embedder_added() {

24 // NoSuchMethodError: The getter 'apiSignature' was called on null.

25 // Receiver: null

26 // Tried calling: apiSignature

27 // dart:core Object .noSuchMethod

28 // package:analyzer/src/dart/analysis/driver.dart 460:20 Analys isDriver.configure

29 // package:analysis_server/src/context_manager.dart 1043:16 Contex tManagerImpl._checkForPackagespecUpdate

30 // package:analysis_server/src/context_manager.dart 1553:5 Contex tManagerImpl._handleWatchEvent

31 //return super.test_embedder_added();

32 fail('NoSuchMethodError');

33 }

34 }

35

36 @reflectiveTest

37 class ContextManagerWithNewOptionsTest_Driver

38 extends ContextManagerWithNewOptionsTest {

39 bool get enableAnalysisDriver => true;

40

41 @failingTest

42 test_analysis_options_file_delete_with_embedder() async {

43 // This fails because the ContextBuilder doesn't pick up the strongMode

44 // flag from the embedder.yaml file.

45 return super.test_analysis_options_file_delete_with_embedder();

46 }

47

48 @failingTest

49 test_embedder_options() async {

50 // This fails because the ContextBuilder doesn't pick up the strongMode

51 // flag from the embedder.yaml file.

52 return super.test_embedder_options();

53 }

54

55 @failingTest

56 test_optionsFile_update_strongMode() async {

57 // It appears that this fails because we are not correctly updating the

58 // analysis options in the driver when the file is modified.

59 //return super.test_optionsFile_update_strongMode();

60 // After a few other changes, the test now times out on my machine, so I'm

61 // disabling it in order to prevent it from being flaky.

62 fail('Test times out');

63 }

64

65 @failingTest

66 test_path_filter_analysis_option() async {

67 // This fails because we're not analyzing the analysis options file.

68 return super.test_path_filter_analysis_option();

69 }

70 }

71

72 @reflectiveTest

73 class ContextManagerWithOldOptionsTest_Driver

74 extends ContextManagerWithOldOptionsTest {

75 bool get enableAnalysisDriver => true;

76

77 @failingTest

78 test_analysis_options_file_delete_with_embedder() async {

79 // This fails because the ContextBuilder doesn't pick up the strongMode

80 // flag from the embedder.yaml file.

81 return super.test_analysis_options_file_delete_with_embedder();

82 }

83

84 @failingTest

85 test_embedder_options() async {

86 // This fails because the ContextBuilder doesn't pick up the strongMode

87 // flag from the embedder.yaml file.

88 return super.test_embedder_options();

89 }

90

91 @failingTest

92 test_optionsFile_update_strongMode() async {

93 // It appears that this fails because we are not correctly updating the

94 // analysis options in the driver when the file is modified.

95 //return super.test_optionsFile_update_strongMode();

96 // After a few other changes, the test now times out on my machine, so I'm

97 // disabling it in order to prevent it from being flaky.

98 fail('Test times out');

99 }

100

101 @failingTest

102 test_path_filter_analysis_option() async {

103 // This fails because we're not analyzing the analysis options file.

104 return super.test_path_filter_analysis_option();

105 }

106 }

OLD	NEW