Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
index 0b4acb909b221e7ce93639be2fc3c31fbbf21e9f..43cd1a4ec468de5b4a33b6da4e2d434cf2bc859b 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
@@ -13,12 +13,14 @@ import 'abstract_rename.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(RenameClassMemberTest);
- defineReflectiveTests(RenameClassMemberTest_Driver);
});
}
@reflectiveTest
class RenameClassMemberTest extends RenameRefactoringTest {
+ @override
+ bool get enableNewAnalysisDriver => true;
+
test_checkFinalConditions_classNameConflict_sameClass() async {
await indexTestUnit('''
class NewName {
@@ -151,6 +153,7 @@ main(A a) {
expectedMessage: "Renamed method will be invisible in 'my.lib'.");
}
+ @failingTest
test_checkFinalConditions_shadowed_byLocalFunction_inSameClass() async {
await indexTestUnit('''
class A {
@@ -171,6 +174,7 @@ class A {
expectedContextSearch: 'test(); // marker');
}
+ @failingTest
test_checkFinalConditions_shadowed_byLocalVariable_inSameClass() async {
await indexTestUnit('''
class A {
@@ -191,6 +195,7 @@ class A {
expectedContextSearch: 'test(); // marker');
}
+ @failingTest
test_checkFinalConditions_shadowed_byLocalVariable_inSubClass() async {
await indexTestUnit('''
class A {
@@ -899,30 +904,3 @@ class A<NewName> {
''');
}
}
-
-@reflectiveTest
-class RenameClassMemberTest_Driver extends RenameClassMemberTest {
- @override
- bool get enableNewAnalysisDriver => true;
-
- @failingTest
- @override
- test_checkFinalConditions_shadowed_byLocalFunction_inSameClass() {
- return super
- .test_checkFinalConditions_shadowed_byLocalFunction_inSameClass();
- }
-
- @failingTest
- @override
- test_checkFinalConditions_shadowed_byLocalVariable_inSameClass() {
- return super
- .test_checkFinalConditions_shadowed_byLocalVariable_inSameClass();
- }
-
- @failingTest
- @override
- test_checkFinalConditions_shadowed_byLocalVariable_inSubClass() {
- return super
- .test_checkFinalConditions_shadowed_byLocalVariable_inSubClass();
- }
-}

Powered by Google App Engine
This is Rietveld 408576698