Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: pkg/analysis_server/test/services/refactoring/extract_local_test.dart

Issue 2863593004: Remove the non-driver versions of several tests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:convert'; 6 import 'dart:convert';
7 7
8 import 'package:analysis_server/protocol/protocol_generated.dart'; 8 import 'package:analysis_server/protocol/protocol_generated.dart';
9 import 'package:analysis_server/src/services/correction/status.dart'; 9 import 'package:analysis_server/src/services/correction/status.dart';
10 import 'package:analysis_server/src/services/refactoring/extract_local.dart'; 10 import 'package:analysis_server/src/services/refactoring/extract_local.dart';
11 import 'package:analysis_server/src/services/refactoring/refactoring.dart'; 11 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
12 import 'package:test/test.dart'; 12 import 'package:test/test.dart';
13 import 'package:test_reflective_loader/test_reflective_loader.dart'; 13 import 'package:test_reflective_loader/test_reflective_loader.dart';
14 14
15 import 'abstract_refactoring.dart'; 15 import 'abstract_refactoring.dart';
16 16
17 main() { 17 main() {
18 defineReflectiveSuite(() { 18 defineReflectiveSuite(() {
19 defineReflectiveTests(ExtractLocalTest); 19 defineReflectiveTests(ExtractLocalTest);
20 defineReflectiveTests(ExtractLocalTest_Driver);
21 }); 20 });
22 } 21 }
23 22
24 @reflectiveTest 23 @reflectiveTest
25 class ExtractLocalTest extends RefactoringTest { 24 class ExtractLocalTest extends RefactoringTest {
26 ExtractLocalRefactoringImpl refactoring; 25 ExtractLocalRefactoringImpl refactoring;
27 26
27 @override
28 bool get enableNewAnalysisDriver => true;
29
28 test_checkFinalConditions_sameVariable_after() async { 30 test_checkFinalConditions_sameVariable_after() async {
29 await indexTestUnit(''' 31 await indexTestUnit('''
30 main() { 32 main() {
31 int a = 1 + 2; 33 int a = 1 + 2;
32 var res; 34 var res;
33 } 35 }
34 '''); 36 ''');
35 _createRefactoringForString('1 + 2'); 37 _createRefactoringForString('1 + 2');
36 // conflicting name 38 // conflicting name
37 RefactoringStatus status = await refactoring.checkAllConditions(); 39 RefactoringStatus status = await refactoring.checkAllConditions();
(...skipping 1300 matching lines...) Expand 10 before | Expand all | Expand 10 after
1338 List<String> _getCoveringExpressions() { 1340 List<String> _getCoveringExpressions() {
1339 List<String> subExpressions = <String>[]; 1341 List<String> subExpressions = <String>[];
1340 for (int i = 0; i < refactoring.coveringExpressionOffsets.length; i++) { 1342 for (int i = 0; i < refactoring.coveringExpressionOffsets.length; i++) {
1341 int offset = refactoring.coveringExpressionOffsets[i]; 1343 int offset = refactoring.coveringExpressionOffsets[i];
1342 int length = refactoring.coveringExpressionLengths[i]; 1344 int length = refactoring.coveringExpressionLengths[i];
1343 subExpressions.add(testCode.substring(offset, offset + length)); 1345 subExpressions.add(testCode.substring(offset, offset + length));
1344 } 1346 }
1345 return subExpressions; 1347 return subExpressions;
1346 } 1348 }
1347 } 1349 }
1348
1349 @reflectiveTest
1350 class ExtractLocalTest_Driver extends ExtractLocalTest {
1351 @override
1352 bool get enableNewAnalysisDriver => true;
1353 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698