Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2851913002: [DevTools] Do not expose agents on Target

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, shans, dougt+watch_chromium.org, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, je_julie, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, rjwright, lushnikov+blink_chromium.org, dmazzoni, yuzo+watch_chromium.org, darktears, blink-reviews-animation_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not expose agents on Target These are exposed on a Protocol.Dispatcher now, which is passed to SDKModel subclasses exclusively. This makes everyone use model instead of agent ensuring proper capability check. BUG=none

Patch Set 1 #

Patch Set 2 : storage and tests.js #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -400 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/request-name-path.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/waterfall-images.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-headers.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/active-and-passive-subresources-with-cert-errors.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/active-subresource-with-cert-errors.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/blank-origins-not-shown.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/blocked-mixed-content-and-subresources-with-cert-errors.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/failed-request.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/main-origin-assigned-despite-request-missing.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-content-active-and-passive-reload.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-content-and-subresources-with-cert-errors.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-content-reload.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/origin-view-then-interstitial.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/passive-subresource-with-cert-errors.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/security-blocked-mixed-content.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/security-blocked-mixed-content-and-malicious.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/security/security-unknown-resource.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/curl-command.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/cached-sync-computed-styles.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/input-event-warning.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/inspector-backend-commands.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/network/network-filter-http-requests.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/network/network-request-parse-query-params.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/network/network-request-query-string.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-loader.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/report-API-errors.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js View 5 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 3 chunks +13 lines, -8 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js View 1 chunk +2 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/layers/LayerTreeModel.js View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 3 chunks +5 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/RequestAppBannerActionDelegate.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js View 5 chunks +13 lines, -11 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 3 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CPUProfilerModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CookieModel.js View 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/EmulationModel.js View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/LogModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js View 11 chunks +38 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js View 4 chunks +5 lines, -3 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/sdk/OverlayModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 4 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Resource.js View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js View 6 chunks +18 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 4 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Script.js View 6 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js View 1 2 chunks +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js View 2 chunks +21 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 7 chunks +20 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 12 chunks +25 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TracingManager.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2845813003 Patch 20001

Messages

Total messages: 9 (7 generated)
dgozman
Could you please take a look?
3 years, 7 months ago (2017-04-28 21:44:07 UTC) #6
caseq
3 years, 7 months ago (2017-04-29 02:12:53 UTC) #9 
https://codereview.chromium.org/2851913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/Tests.js (right):

https://codereview.chromium.org/2851913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/Tests.js:634: step1() {
here and below -- revert.

https://codereview.chromium.org/2851913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js
(right):

https://codereview.chromium.org/2851913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js:24:
this._target = target;
Is it still necessary?

https://codereview.chromium.org/2851913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js
(right):

https://codereview.chromium.org/2851913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js:427:
if (this._disposeCallback)
Rename to _disconnectCallback.

https://codereview.chromium.org/2851913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js:489: *
@param {!Protocol.Dispatcher} target
This is confusing. Should this be renamed?

https://codereview.chromium.org/2851913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/2851913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:37: * @param
{!Protocol.NetworkAgent} networkAgent
Do we really need both manager and agent here? It feels confusing.

Powered by Google App Engine
This is Rietveld 408576698