Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html

Issue 2851913002: [DevTools] Do not expose agents on Target
Patch Set: storage and tests.js Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html
index fa121cb01bb44256f9f2886079c92a42f3af1fbc..800250d2aa830b0ea2077e1d3b4ed5c6c6aceddf 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html
@@ -6,11 +6,11 @@
function test()
{
- var request1 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://foo.test/", "https://foo.test", 0, 0, null);
+ var request1 = new SDK.NetworkRequest(InspectorTest.networkManager, InspectorTest.NetworkAgent, 0, "https://foo.test/", "https://foo.test", 0, 0, null);
request1.setSecurityState(Protocol.Security.SecurityState.Secure);
InspectorTest.dispatchRequestFinished(request1);
- var request2 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://bar.test/foo.jpg", "https://bar.test", 0, 0, null);
+ var request2 = new SDK.NetworkRequest(InspectorTest.networkManager, InspectorTest.NetworkAgent, 0, "https://bar.test/foo.jpg", "https://bar.test", 0, 0, null);
request2.setSecurityState(Protocol.Security.SecurityState.Secure);
InspectorTest.dispatchRequestFinished(request2);
@@ -20,7 +20,7 @@ function test()
// Test that the sidebar is hidden when an interstitial is shown. https://crbug.com/559150
InspectorTest.mainTarget.model(SDK.ResourceTreeModel).dispatchEventToListeners(SDK.ResourceTreeModel.Events.InterstitialShown);
// Simulate a request finishing after the interstitial is shown, to make sure that doesn't show up in the sidebar.
- var request3 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://bar.test/foo.jpg", "https://bar.test", 0, 0, null);
+ var request3 = new SDK.NetworkRequest(InspectorTest.networkManager, InspectorTest.NetworkAgent, 0, "https://bar.test/foo.jpg", "https://bar.test", 0, 0, null);
request3.setSecurityState(Protocol.Security.SecurityState.Unknown);
InspectorTest.dispatchRequestFinished(request3);
InspectorTest.addResult("After interstitial is shown:");

Powered by Google App Engine
This is Rietveld 408576698