[DevTools] Host paint profiles in PaintProfilerModel

[DevTools] Host paint profiles in PaintProfilerModel

This ensures proper capability check.

BUG=none

Review-Url: https://codereview.chromium.org/2845813003
Cr-Commit-Position: refs/heads/master@{#468108}
Committed: https://chromium.googlesource.com/chromium/src/+/39206f00c8d9dd41a217c315fc0c0376f5848408

[dgozman, 2017-04-27 05:45:58]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 05:46:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 07:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 07:33:09]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-27 16:25:32]

dgozman@chromium.org changed reviewers:
+ alph@chromium.org

[dgozman, 2017-04-27 16:25:32]

Take a look please.

[dgozman, 2017-04-27 16:55:59]

Description was changed from

==========
[DevTools] Host paint profiles in PaintProfilerModel

This ensures proper capability check.

BUG=none
==========

to

==========
[DevTools] Host paint profiles in PaintProfilerModel

This ensures proper capability check.

BUG=none
==========

[dgozman, 2017-04-27 16:56:00]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq1, 2017-04-27 21:19:22]

caseq@google.com changed reviewers:
+ caseq@google.com

[caseq1, 2017-04-27 21:19:22]

lgtm

https://codereview.chromium.org/2845813003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js (right):

https://codereview.chromium.org/2845813003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js:62:
layerSnapshot(layerId) {
Let's keep the underlying name, i.e. makeSnapshot() -- the verb is fairly
important here to show it's not just a getter and we're creating a new snapshot
each time.

https://codereview.chromium.org/2845813003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js
(left):

https://codereview.chromium.org/2845813003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js:390:
if (!fragments.length || !this._target)
That's about the only place we needed target here, so perhaps you want to
convert this one to keep PaintProfilerModel as well?

[dgozman, 2017-04-28 00:07:33]

https://codereview.chromium.org/2845813003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js (right):

https://codereview.chromium.org/2845813003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js:62:
layerSnapshot(layerId) {
On 2017/04/27 21:19:22, caseq1 wrote:
> Let's keep the underlying name, i.e. makeSnapshot() -- the verb is fairly
> important here to show it's not just a getter and we're creating a new
snapshot
> each time.

Done.

https://codereview.chromium.org/2845813003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js
(left):

https://codereview.chromium.org/2845813003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js:390:
if (!fragments.length || !this._target)
On 2017/04/27 21:19:22, caseq1 wrote:
> That's about the only place we needed target here, so perhaps you want to
> convert this one to keep PaintProfilerModel as well?

Done.

[dgozman, 2017-04-28 18:20:19]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-04-28 18:20:19]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@google.com
Link to the patchset: https://codereview.chromium.org/2845813003/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-04-28 18:21:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 20:20:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493403619329660,
"parent_rev": "fd1f401a843ef214df3818fe714aa7303d27261d", "commit_rev":
"39206f00c8d9dd41a217c315fc0c0376f5848408"}

[commit-bot: I haz the power, 2017-04-28 20:20:56]

Description was changed from

==========
[DevTools] Host paint profiles in PaintProfilerModel

This ensures proper capability check.

BUG=none
==========

to

==========
[DevTools] Host paint profiles in PaintProfilerModel

This ensures proper capability check.

BUG=none

Review-Url: https://codereview.chromium.org/2845813003
Cr-Commit-Position: refs/heads/master@{#468108}
Committed:
https://chromium.googlesource.com/chromium/src/+/39206f00c8d9dd41a217c315fc0c...
==========

[commit-bot: I haz the power, 2017-04-28 20:20:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/39206f00c8d9dd41a217c315fc0c...