third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state.html - Issue 2851913002: [DevTools] Do not expose agents on Target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state.html

Issue 2851913002: [DevTools] Do not expose agents on Target

Patch Set: storage and tests.js Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/security-blocked-mixed-content-and-malicious.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html » ('j') | third_party/WebKit/Source/devtools/front_end/Tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state.html

index 7abcf2bbaea6b06fd1d2c6d52fe8e1dfa018709e..dc4992e5324138aacb3d7579242246ccb9aa9d93 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state.html

@@ -6,17 +6,17 @@

function test()

{

// Add a request without security details.

- const request1 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://foo.test/foo.jpg", "https://foo.test", 0, 0, null);

+ const request1 = new SDK.NetworkRequest(InspectorTest.networkManager, InspectorTest.NetworkAgent, 0, "https://foo.test/foo.jpg", "https://foo.test", 0, 0, null);

request1.setSecurityState(Protocol.Security.SecurityState.Unknown);

InspectorTest.dispatchRequestFinished(request1);

// Add an unrelated request.

- const request2 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://bar.test/bar.jpg", "https://bar.test", 0, 0, null);

+ const request2 = new SDK.NetworkRequest(InspectorTest.networkManager, InspectorTest.NetworkAgent, 0, "https://bar.test/bar.jpg", "https://bar.test", 0, 0, null);

request2.setSecurityState(Protocol.Security.SecurityState.Unknown);

InspectorTest.dispatchRequestFinished(request2);

// Add a request to the first origin, this time including security details.

- const request3 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://foo.test/foo2.jpg", "https://foo.test", 0, 0, null);

+ const request3 = new SDK.NetworkRequest(InspectorTest.networkManager, InspectorTest.NetworkAgent, 0, "https://foo.test/foo2.jpg", "https://foo.test", 0, 0, null);

request3.setSecurityState(Protocol.Security.SecurityState.Secure);

let securityDetails = {};

securityDetails.protocol = "TLS 1.2";