third_party/WebKit/LayoutTests/http/tests/inspector/security/main-origin-assigned-despite-request-missing.html - Issue 2851913002: [DevTools] Do not expose agents on Target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/main-origin-assigned-despite-request-missing.html

Issue 2851913002: [DevTools] Do not expose agents on Target

Patch Set: storage and tests.js Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/security/mixed-content-active-and-passive-reload.html » ('j') | third_party/WebKit/Source/devtools/front_end/Tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/main-origin-assigned-despite-request-missing.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/main-origin-assigned-despite-request-missing.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/main-origin-assigned-despite-request-missing.html

index bf22953812baee3adf2cba6ebc6b6aa11b3ee13e..733a45d3e545513c048d2408a674edb1f7c50d46 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/main-origin-assigned-despite-request-missing.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/main-origin-assigned-despite-request-missing.html

@@ -19,13 +19,13 @@

InspectorTest.addResult("Detected main origin: " + detectedMainOrigin);

// Send subdownload resource requests to other origins.

- const request1 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://foo.test/favicon.ico", page_url, 0, 0, null);

+ const request1 = new SDK.NetworkRequest(InspectorTest.networkManager, InspectorTest.NetworkAgent, 0, "https://foo.test/favicon.ico", page_url, 0, 0, null);

InspectorTest.dispatchRequestFinished(request1);

- const request2 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "https://bar.test/bar.css", page_url, 0, 0, null);

+ const request2 = new SDK.NetworkRequest(InspectorTest.networkManager, InspectorTest.NetworkAgent, 0, "https://bar.test/bar.css", page_url, 0, 0, null);

InspectorTest.dispatchRequestFinished(request2);

// Send one request to the Same Origin as the original page to ensure it appears in the group.

- const request3 = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, detectedMainOrigin + "/favicon.ico", page_url, 0, 0, null);

+ const request3 = new SDK.NetworkRequest(InspectorTest.networkManager, InspectorTest.NetworkAgent, 0, detectedMainOrigin + "/favicon.ico", page_url, 0, 0, null);

InspectorTest.dispatchRequestFinished(request3);

InspectorTest.dumpSecurityPanelSidebarOrigins();

InspectorTest.completeTest();