Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: third_party/WebKit/Source/devtools/front_end/Tests.js

Issue 2851913002: [DevTools] Do not expose agents on Target
Patch Set: storage and tests.js Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/Tests.js
diff --git a/third_party/WebKit/Source/devtools/front_end/Tests.js b/third_party/WebKit/Source/devtools/front_end/Tests.js
index b0c51b9ef39a1d739d8faec5e8a17fc1041d306e..2b8f5dc596735df00ef4883ab96d7c1f1c552f64 100644
--- a/third_party/WebKit/Source/devtools/front_end/Tests.js
+++ b/third_party/WebKit/Source/devtools/front_end/Tests.js
@@ -620,7 +620,7 @@
var test = this;
async function testOverrides(params, metrics, callback) {
- await SDK.targetManager.mainTarget().emulationAgent().invoke_setDeviceMetricsOverride(params);
+ await SDK.targetManager.mainTarget()._dispatcher.emulationAgent().invoke_setDeviceMetricsOverride(params);
test.evaluateInConsole_('(' + dumpPageMetrics.toString() + ')()', checkMetrics);
function checkMetrics(consoleResult) {
@@ -630,31 +630,36 @@
}
}
- function step1() {
+ function
+ step1() {
caseq 2017/04/29 02:12:53 here and below -- revert.
testOverrides(
{width: 1200, height: 1000, deviceScaleFactor: 1, mobile: false, fitWindow: true},
{width: 1200, height: 1000, deviceScaleFactor: 1}, step2);
}
- function step2() {
+ function
+ step2() {
testOverrides(
{width: 1200, height: 1000, deviceScaleFactor: 1, mobile: false, fitWindow: false},
{width: 1200, height: 1000, deviceScaleFactor: 1}, step3);
}
- function step3() {
+ function
+ step3() {
testOverrides(
{width: 1200, height: 1000, deviceScaleFactor: 3, mobile: false, fitWindow: true},
{width: 1200, height: 1000, deviceScaleFactor: 3}, step4);
}
- function step4() {
+ function
+ step4() {
testOverrides(
{width: 1200, height: 1000, deviceScaleFactor: 3, mobile: false, fitWindow: false},
{width: 1200, height: 1000, deviceScaleFactor: 3}, finish);
}
- function finish() {
+ function
+ finish() {
test.releaseControl();
}
@@ -663,9 +668,9 @@
};
TestSuite.prototype.testDispatchKeyEventDoesNotCrash = function() {
- SDK.targetManager.mainTarget().inputAgent().invoke_dispatchKeyEvent(
+ SDK.targetManager.mainTarget()._dispatcher.inputAgent().invoke_dispatchKeyEvent(
{type: 'rawKeyDown', windowsVirtualKeyCode: 0x23, key: 'End'});
- SDK.targetManager.mainTarget().inputAgent().invoke_dispatchKeyEvent(
+ SDK.targetManager.mainTarget()._dispatcher.inputAgent().invoke_dispatchKeyEvent(
{type: 'keyUp', windowsVirtualKeyCode: 0x23, key: 'End'});
};

Powered by Google App Engine
This is Rietveld 408576698