third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py - Issue 2851913002: [DevTools] Do not expose agents on Target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py

Issue 2851913002: [DevTools] Do not expose agents on Target

Patch Set: storage and tests.js Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js ('K') | « third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py

diff --git a/third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py b/third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py

index c6d0c3b23d5ba3a7aa76776db43b4f444d5ea716..dfd814729b5ec73c83d0a5dc980954ff1d6c5f84 100755

--- a/third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py

+++ b/third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py

@@ -242,11 +242,11 @@ def generate_protocol_externs(output_path, file1, file2):

uppercase_length += 1

output_file.write("/** @return {!Protocol.%sAgent}*/\n" % domain_name)

- output_file.write("Protocol.TargetBase.prototype.%s = function(){};\n" %

+ output_file.write("Protocol.Dispatcher.prototype.%s = function(){};\n" %

(domain_name[:uppercase_length].lower() + domain_name[uppercase_length:] + "Agent"))

output_file.write("/**\n * @param {!Protocol.%sDispatcher} dispatcher\n */\n" % domain_name)

- output_file.write("Protocol.TargetBase.prototype.register%sDispatcher = function(dispatcher) {}\n" % domain_name)

+ output_file.write("Protocol.Dispatcher.prototype.register%sDispatcher = function(dispatcher) {}\n" % domain_name)

output_file.close()