Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/Main.js

Issue 2851913002: [DevTools] Do not expose agents on Target
Patch Set: storage and tests.js Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/main/Main.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/Main.js b/third_party/WebKit/Source/devtools/front_end/main/Main.js
index fe21176a867e053d8beadc3a1374eedd5d822785..e813b9e7bcce5a9dee0238843906ea9755da8282 100644
--- a/third_party/WebKit/Source/devtools/front_end/main/Main.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/Main.js
@@ -204,7 +204,6 @@ Main.Main = class {
new Main.Main.InspectedNodeRevealer();
new Main.NetworkPanelIndicator();
new Main.SourcesPanelIndicator();
- new Main.BackendSettingsSync();
UI.actionRegistry = new UI.ActionRegistry();
UI.shortcutRegistry = new UI.ShortcutRegistry(UI.actionRegistry, document);
@@ -446,11 +445,12 @@ Main.Main = class {
Main.Main.InspectorModel = class extends SDK.SDKModel {
/**
* @param {!SDK.Target} target
+ * @param {!Protocol.Dispatcher} dispatcher
*/
- constructor(target) {
- super(target);
- target.registerInspectorDispatcher(this);
- target.inspectorAgent().enable();
+ constructor(target, dispatcher) {
+ super(target, dispatcher);
+ dispatcher.registerInspectorDispatcher(this);
+ dispatcher.inspectorAgent().enable();
}
/**
@@ -902,44 +902,6 @@ Main.TargetCrashedScreen = class extends UI.VBox {
/**
- * @implements {SDK.TargetManager.Observer}
- * @unrestricted
- */
-Main.BackendSettingsSync = class {
- constructor() {
- this._autoAttachSetting = Common.settings.moduleSetting('autoAttachToCreatedPages');
- this._autoAttachSetting.addChangeListener(this._update, this);
- SDK.targetManager.observeTargets(this, SDK.Target.Capability.Browser);
- }
-
- /**
- * @param {!SDK.Target} target
- */
- _updateTarget(target) {
- target.pageAgent().setAutoAttachToCreatedPages(this._autoAttachSetting.get());
- }
-
- _update() {
- SDK.targetManager.targets(SDK.Target.Capability.Browser).forEach(this._updateTarget, this);
- }
-
- /**
- * @param {!SDK.Target} target
- * @override
- */
- targetAdded(target) {
- this._updateTarget(target);
- }
-
- /**
- * @param {!SDK.Target} target
- * @override
- */
- targetRemoved(target) {
- }
-};
-
-/**
* @implements {UI.SettingUI}
* @unrestricted
*/

Powered by Google App Engine
This is Rietveld 408576698